-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Uploads update to 3.0 #13344
Comments
@Rick-Anderson I'm going to backlog this one due to special circumstances. There are massive updates for the 2.2 version on #12344. We should get those approved+merged first, then update the topic+sample to 3.0. I just took a look, and adding 3.0 updates to that PR would make it even more 😵. |
I would add the 3.0 updates to this PR when you have time. That's what I did on a couple PR's that languished for months. |
Let's do it after the major updates go in on that PR. That PR is one of the largest topic+sample updates I've ever done ... It's a 👹 B E A S T 👹 ... took me a full week ... and explains why we're having trouble getting it reviewed, too. After all of that goes in, then it will be a snap to get it up to 3.0. What I don't want to do is add the 3.0 updates to that PR. Alternately trying to update the current topic to 3.0 is even more insane ... the current topic+sample is a 🚂💥, and touching it will create major conflicts with the existing PR. |
It looks like the current file upload guidance for large files stops functioning as expected in 3.0. IIS grabbs the entire stream and writes it to disk, then hands things off to the controller method. Rather than the stream being accessible in the controller method through the |
A note: to make large file upload sample work in .NET Core 3.0 RTM [AttributeUsage(AttributeTargets.Class | AttributeTargets.Method)]
public class DisableFormValueModelBindingAttribute : Attribute, IResourceFilter
{
public void OnResourceExecuting(ResourceExecutingContext context)
{
var factories = context.ValueProviderFactories;
factories.RemoveType<FormValueProviderFactory>();
factories.RemoveType<FormFileValueProviderFactory>();
factories.RemoveType<JQueryFormValueProviderFactory>();
}
public void OnResourceExecuted(ResourceExecutedContext context)
{
}
} |
@attribute [RequestSizeLimitAttribute(52428800)]
in the cshtml. https://github.com/aspnet/AspNetCore.Docs/pull/12344/files#r329287769Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
The text was updated successfully, but these errors were encountered: