Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Uploads update to 3.0 #13344

Closed
guardrex opened this issue Jul 16, 2019 — with docs.microsoft.com · 5 comments · Fixed by #14770
Closed

File Uploads update to 3.0 #13344

guardrex opened this issue Jul 16, 2019 — with docs.microsoft.com · 5 comments · Fixed by #14770
Assignees
Labels

Comments

Copy link
Collaborator

guardrex commented Jul 16, 2019


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@dotnet-bot dotnet-bot added the Source - Docs.ms Docs Customer feedback via GitHub Issue label Jul 16, 2019
@guardrex guardrex self-assigned this Jul 16, 2019
@guardrex guardrex added 3.0 Pri1 and removed Source - Docs.ms Docs Customer feedback via GitHub Issue labels Jul 16, 2019
@guardrex guardrex added this to the Backlog milestone Jul 16, 2019
@guardrex guardrex modified the milestones: Backlog, 3.0 Aug 6, 2019
@guardrex
Copy link
Collaborator Author

@Rick-Anderson I'm going to backlog this one due to special circumstances. There are massive updates for the 2.2 version on #12344. We should get those approved+merged first, then update the topic+sample to 3.0. I just took a look, and adding 3.0 updates to that PR would make it even more 😵.

@guardrex guardrex removed the 3.0 label Sep 16, 2019
@guardrex guardrex modified the milestones: 3.0, Backlog Sep 16, 2019
@Rick-Anderson
Copy link
Contributor

I would add the 3.0 updates to this PR when you have time. That's what I did on a couple PR's that languished for months.

@guardrex
Copy link
Collaborator Author

Let's do it after the major updates go in on that PR. That PR is one of the largest topic+sample updates I've ever done ... It's a 👹 B E A S T 👹 ... took me a full week ... and explains why we're having trouble getting it reviewed, too. After all of that goes in, then it will be a snap to get it up to 3.0. What I don't want to do is add the 3.0 updates to that PR. Alternately trying to update the current topic to 3.0 is even more insane ... the current topic+sample is a 🚂💥, and touching it will create major conflicts with the existing PR.

@douglasg14b
Copy link

It looks like the current file upload guidance for large files stops functioning as expected in 3.0. IIS grabbs the entire stream and writes it to disk, then hands things off to the controller method. Rather than the stream being accessible in the controller method through the HttpRequest

Copy link

FeodorFitsner commented Sep 27, 2019

A note: to make large file upload sample work in .NET Core 3.0 RTM DisableFormValueModelBinding source should be changed to:

[AttributeUsage(AttributeTargets.Class | AttributeTargets.Method)]
public class DisableFormValueModelBindingAttribute : Attribute, IResourceFilter
{
    public void OnResourceExecuting(ResourceExecutingContext context)
    {
        var factories = context.ValueProviderFactories;
        factories.RemoveType<FormValueProviderFactory>();
        factories.RemoveType<FormFileValueProviderFactory>();
        factories.RemoveType<JQueryFormValueProviderFactory>();
    }

    public void OnResourceExecuted(ResourceExecutedContext context)
    {
    }
}  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants