-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document cache tag helper in response caching doc #1948
Comments
@tdykstra Want me to knock this out? Come on, do you want me to beg? Do you want me on my knees, crying?- Fifi Macaffee (Roger Ward), Mad Max, 1979 |
@guardrex Yes, please. |
@tdykstra A few problems here:
Another alternative here is to punt 🏈 : Mention that these Tag Helpers exist in a section at the end of the doc and then link to the .NET Monsters video on the subject on Channel 9: https://channel9.msdn.com/Series/aspnetmonsters/Episode-35-Distributed-Cache-Tag-Helper How do you want to proceed? |
I'll defer to @danroth27 |
@guardrex put it under https://docs.microsoft.com/en-us/aspnet/core/mvc/views/tag-helpers/intro |
👍 Will do. |
@guardrex what took you so long to respond (sarcasm warning)? |
I'm at the 💪 gym 💪 and the weights are trying to kill me today. 💀 I just got pinned to the bench! 😄 |
@Rick-Anderson I'll be knocking up the outline this evening, but just to clarify the doc location ...
Do you want the doc, |
tag-helpers folder |
thought so. thx. |
I almost have the outline ready. A few questions here ...
|
@kichalla can you respond to outline questions. I responded inline with my guesses |
With @Rick-Anderson comments, this is what the draft outline looks like ... Title: Caching tag helpers (
|
Isn't this covered now by https://github.com/aspnet/Docs/pull/2644/files#diff-1ce85b6d78dcd047d3358068e57048c9 |
@pkellner don't you cover this? |
@Rick-Anderson He did ... covered by #2644 |
@Rick-Anderson @guardrex I'd say yes and no. The "Built in Tag Helper" doc's I'm doing are targeting the user of tags. That is, primarily focussed around how to use the attributes associated with the tags and their implications (along with short examples). The "Yes" part of the answer is that I say in the Distributed Cache Tag Helper doc
Because there are two built in implementations, I feel obligated to mention them as well as have a reference to an article that gives many more details about configurations.
Finally, I think details about how to build your own distributed cache implementation (including what methods need implementing) should be in a separate document along with a fully documented reference implementation. LMK if you agree. Happy to update what I've done accordingly. Currently, I've got in my branch both the Distributed Cache and Cache Tag Helpers documented as I thought appropriate. |
@Rick-Anderson @guardrex Forgot to mention the "no" part of the answer is that I was not planning on doing the detailed doc on how to implement your own distributed cache tag helper. I'd be open to talking about it later, but for the moment, I'm focussed and committed to getting all the built in tag helpers documented as I described above. |
@pkellner I didn't intend for you to cover implement your own distributed cache tag helper, just doc'ing the built in TH. |
@Rick-Anderson I'm mostly looking for guidance on what to cover in Distributed Cache Tag Helper and what not do. In the branch below I've done the following. I'm open to changing what I've done based on guidance.
My thinking is that these are all detailed (and will be maintained I assume) on other doc pages. |
@pkellner That sounds reasonable. |
No description provided.
The text was updated successfully, but these errors were encountered: