Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update module import approach in import/export JS interop examples #29544

Closed
guardrex opened this issue Jun 16, 2023 · 0 comments · Fixed by #29545
Closed

Update module import approach in import/export JS interop examples #29544

guardrex opened this issue Jun 16, 2023 · 0 comments · Fixed by #29545
Assignees
@guardrex
Labels
Blazor doc-bug Pri0 Urgent priority Source - Docs.ms Docs Customer feedback via GitHub Issue

Comments

@guardrex
Copy link
Collaborator

guardrex commented Jun 16, 2023 •
edited
Loading

Let's use OnAfterRenderAsync to load the module for the example ...

dotnet/runtime#87690 (comment)

I'll check the others here and mirror the choice. I'm making a follow-up note on a tracking issue to check-in with Pavel when he gets back next week to confirm that he's ok with the change.

The current approach has a problem on first render ...

image

Although the module code runs fine on the follow-up render, we'll adopt Steve's approach from his MapBox JS interop example.

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guardrex guardrex

Labels
Blazor doc-bug Pri0 Urgent priority Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
Blazor.Docs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update module import approach dotnet/AspNetCore.Docs
2 participants
@guardrex @dotnet-bot