-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InteractiveAuto behavior needs more details regarding when it's using WebAssembly. #31228
Comments
🍂🎁 Happy Holidays! ❄️⛄A green dinosaur 🦖 will be along shortly to assist. Stand-by ........ |
Thanks @breakerofbuilds ... I agree; but in the third case, I would guess the Auto page runs initially with WASM because the WASM runtime is active. @MackinnonBuck ... Can you clarify what "on future visits" means? I'll add remarks to the article. |
There's one thing that we'll probably need to add (I'll look on Monday to see how we're handling it) ... Auto components are still prerendered on the server. Therefore, we'll need to make sure that it's clear that even if the Blazor runtime is active on the client, there's a prerendering step on the server. Then, we need to flesh out if page transitions affect CSR. I don't think so ... I think after the Blazor client becomes active (and after prerendering) that Auto components always render on the client. However, I assumed that was the case from product unit remarks and didn't inquire further. |
Perhaps, the line that can cover it is ...
.... something along those lines. When Mackinnon gets on, he'll be able to say if that's accurate. |
It may be correct but missing clarification for this crucial part:
The missing information here is: When is the runtime activated? I assumed incorrectly that it would activate whenever the runtime was cached(and the page reloaded after being cached the first time). |
That should be true tho. I have a feeling that we might hit a problem that Steve Sanderson has called out several times about lifecycle methods over the years, namely that our documentation isn't going to be able to cover exactly when things happen because the framework is complicated and timing is a bit arbitrary (e.g., network lags, task completion, etc.). The runtime activates after it and the app bundle are downloaded, and we might not be able to be more specific than that. Mackinnon can comment on this aspect as well. |
I see. Then the problem I see with the documentation is that is makes statements based on conditions that are undefined(runtime being loaded).
In the next paragraph it says:
Instead it could say something like this.
And in the second paragraph:
Into
|
No, your proposed language isn't correct based on what they told me. I was told that if the app bundle and runtime are cached on the client they will be used for Auto component rendering (i.e., WASM will be used at that point). If you can demonstrate that isn't the case, you'd need to open an issue on the PU's repo to show them. You may have found a bug in the framework. |
What I'm saying is that the exact timing of when that happens is indeterminate ... when the download is finished and exactly when the runtime starts. AFAIK, that can't be predicted exactly. |
Ok, my initial observation was that the rendermode used with Auto was determined by what rendermode the user was navigating from. I will open a bug report. |
... and whatever might be going on like that we would need to get in. These articles were all checked over by the PU, but behaviors and details do sometimes get left out on the first pass setting up new docs. Please add ...
... to the bottom of your opening comment of your PU issue so that I can follow along. I still want to work on the text. Leave this open. It will close automatically later when the PR merges. |
Thanks @breakerofbuilds ... That's perfect. I'll keep an 👂 open there for their response. |
Ok ... now we know. 😄 Indeed! The full logic wasn't explained to me when we put the coverage up. I'll get to this fairly fast ... next week tho. I'm buried in other work at the moment trying to get our 8.0 snippet sample apps in place and cross-linked for doc snippets. I'll get back to this as soon as I can 🏃♂️🏃♂️🏃♂️🏃♂️🏃♂️🏃♂️🏃♂️🏃♂️🏃♂️🏃♂️😅. |
same issue :dotnet/aspnetcore#52719 |
It's already cross-linked via @breakerofbuilds's issue. I see the related ones ... Artak probably marked all of them. I'll survey all of them when I work on this. |
UPDATE ... I'm trying to get back to this issue, but I'm a bit ⛰️⛏️😅 at the moment on other high priority work items. I hope to reach this issue next week before taking off for the holiday break ⛄. |
OK ... I'm finally 😅 BACK! 😄 I've been buried in work for weeks, often putting out emergency 🔥🚒 that have cropped up in coverage. I'm going to see about resolving this issue now. |
Description
The article says:
Which I interpret as once the client is fully downloaded the Auto will use WebAssembly from there on.
Examples
Thus "future visits" need to be clarified that it depends on how the visitor navigates and not only whether the runtime and app is fully downloaded.
Page URL
https://learn.microsoft.com/en-us/aspnet/core/blazor/components/render-modes?view=aspnetcore-8.0#automatic-auto-rendering
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/blazor/components/render-modes.md
Document ID
7c9948a3-9886-8097-6014-492a4c21ea4e
Article author
@guardrex
The text was updated successfully, but these errors were encountered: