Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1 Update config for 2.x Azure KV config provider topic samples #4211

Closed
guardrex opened this issue Sep 5, 2017 · 2 comments
Closed

2.1 Update config for 2.x Azure KV config provider topic samples #4211

guardrex opened this issue Sep 5, 2017 · 2 comments
Assignees

Comments

@guardrex
Copy link
Collaborator

guardrex commented Sep 5, 2017

Based on the updates to config for 2.1 adding chained config, we can move the 2.x Azure Key Vault config provider topic samples (sample 1, sample 2) to a nicer config setup ...

WebHost.CreateDefaultBuilder(args)
    .ConfigureAppConfiguration((context, config) =>
    {
        var builtConfig = config.Build();

        var keyVaultConfigBuilder = new ConfigurationBuilder();

        keyVaultConfigBuilder.AddAzureKeyVault(
           $"https://{builtConfig["Vault"]}.vault.azure.net/",
           builtConfig["ClientId"],
           builtConfig["ClientSecret"];

        config.AddConfiguration(keyVaultConfigBuilder);
   })
   .Build()

@scottaddie Can you create a label for 2.1 for this? ... or mark it blocked right now?

@scottaddie scottaddie added the 2.1 label Sep 6, 2017
@scottaddie
Copy link
Member

@guardrex Label created and applied

@Rick-Anderson Rick-Anderson added this to the Backlog milestone Sep 25, 2017
@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Sep 25, 2017

Make sure this is updated to the latest version without tabs from previous versions. If you need previous versions, point to https://github.com/aspnet/Docs/blob/master/aspnetcore/common/_static/9-25-17.pdf

This is revised: Keep the 1.x samp, update the 2.0 samp to 2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants