Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddIdentity vs. AddDefaultIdentity vs. AddIdentityCore #7633

Closed
IndigoHealth opened this issue Jul 15, 2018 — with docs.microsoft.com · 4 comments
Closed

AddIdentity vs. AddDefaultIdentity vs. AddIdentityCore #7633

IndigoHealth opened this issue Jul 15, 2018 — with docs.microsoft.com · 4 comments
Assignees
Labels
Source - Docs.ms Docs Customer feedback via GitHub Issue

Comments

Copy link

IndigoHealth commented Jul 15, 2018

These pages sometimes say we should use services.AddDefaultIdentity, and sometimes services.AddIdentity. Reading between the lines, AddIdentity exposes additional options for configuring Identity. But there is no coherent description of the difference between these two methods. We really need a section early in this documentation that presents these two registration methods and information about the follow-on fluent methods that are required and/or optional.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@Rick-Anderson
Copy link
Contributor

@sbsw thanks for pointing this out. See #6367
Closing as a duplicate of #6367.

@Rick-Anderson Rick-Anderson added the Source - Docs.ms Docs Customer feedback via GitHub Issue label Jul 16, 2018
@Rick-Anderson Rick-Anderson reopened this Sep 6, 2018
@Rick-Anderson Rick-Anderson changed the title AddIdentity vs. AddDefaultIdentity AddIdentity vs. AddDefaultIdentity vs. AddIdentityCore Sep 6, 2018
@Rick-Anderson
Copy link
Contributor

@sbsw thanks for this. I've moved it to #8434 and plan on providing a link to the new section in this doc. Would that work for you?

@IndigoHealth
Copy link
Author

Thanks @Rick-Anderson that would be great. Since I wrote this issue, I've stumbled across various conflicting examples that purport to show the calls one would need with AddIdentity to replicate AddDefaultIdentity. In any case, it's a nontrivial amount of code, none of which is clearly explained in the code examples.

As an aside, I want to give you guys kudos for the great documentation, with coherent explanations and great examples. In particular, I appreciate the highlighted code in the examples that ties in with the discussion.

@Rick-Anderson
Copy link
Contributor

Per Haok
AddDefaultIdentity is similar to AddIdentity + AddDefaultTokens + AddDefaultUI

@dotnet dotnet locked and limited conversation to collaborators Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
None yet
Development

No branches or pull requests

2 participants