Add logging 2.1 to 2.2/3.0 migration guide #10122

pakrym · 2018-12-27T19:03:15Z

pakrym · 2018-12-27T19:13:02Z

guardrex · 2018-12-27T19:20:47Z

@pakrym We usually use our in-topic versioning (in this case, in the Logging topic) to cover updates to the framework and then call out the migration steps in the migration topic (in this case, Migrate from ASP.NET Core 2.1 to 2.2). Idk what they'll suggest, but the pattern has been not to have migration topics in the Fundamentals node. Pinging Sir @tdykstra for help.

tdykstra · 2018-12-28T17:13:49Z

That's right, this should go in https://github.com/aspnet/Docs/blob/master/aspnetcore/migration/21-to-22.md. We don't have a place for the 3.0 instructions yet, but they will end up in a 3.0 migration doc located in the same folder.

pakrym · 2018-12-28T17:20:07Z

Should I make two copies of this doc then?

pakrym · 2018-12-28T19:27:46Z

There are also some parts that are not ASP.NET Core specific and apply to console apps too.

tdykstra · 2018-12-28T21:17:11Z

There's an outstanding issue for writing logging docs that aren't ASP.NET Core-specific --

dotnet/docs#4567

Until that is resolved I would put the 2.1 to 2.2 content in the 2.1 to 2.2 doc, and publish the non-ASP.NET-Core content and the 3.0 content in a blog for now.

Considering the dialog in aspnet/Logging#932, I would also link from the logging doc to the new 2.1 to 2.2 logging section of the migration doc to make that more discoverable.

cc @Rick-Anderson in cases he has any other ideas about where to put non-ASP.NET Core and migrate-to-3.0 content.

Rick-Anderson · 2018-12-28T22:05:27Z

@tdykstra can you help move the content around for @pakrym in exchange for him helping use on technical content?

tdykstra · 2018-12-28T22:06:51Z

What about blogging the 3.0 and non-ASP.NET parts?

pakrym · 2018-12-28T22:08:45Z

What about blogging the 3.0 and non-ASP.NET parts?

I think they might need to be referenced from EF logging doc (https://docs.microsoft.com/en-us/ef/core/miscellaneous/logging)

tdykstra · 2018-12-28T22:14:30Z

We could add the non-ASP.NET Core content there until we get a permanent home for it, that leaves 3.0. Maybe just start a 2.2-to-3.0 migration doc that only has this logging content in it for now?

tdykstra · 2018-12-28T22:17:13Z

So if this plan makes sense, I'll

Move the 2.1 to 2.2 content to the appropriate migration doc
Move the 3.0 content to a new (very small) 2.2 to 3.0 migration doc
Move the non-ASP.NET Core content to the EF logging doc

pakrym · 2018-12-28T22:20:13Z

Move the non-ASP.NET Core content to the EF logging doc

I'm not a fan of this part, while it's non-ASP.NET Core content it's even less EF specific. I would prefer having it in ASP.NET Core migration doc over EF.

tdykstra · 2018-12-28T22:21:54Z

It's out of place there, but we don't have a better place for it, so I could put it there and link to it from the EF doc.

guardrex · 2018-12-29T23:09:35Z

@tdykstra Caught my 👁️ looking at 3.0 issues ...

Move the 3.0 content to a new (very small) 2.2 to 3.0 migration doc

#9490 ... content that might make a good basis for it ... and potentially helpful for very VERY early adopters playing with the bits.

Rick-Anderson · 2019-01-03T23:51:42Z

@tdykstra can we S&M this? You can move this to a new (very small) 2.2 to 3.0 migration doc after.

tdykstra · 2019-01-04T00:03:53Z

Better to avoid that, it creates a new URL which we would then have to redirect and we wouldn't have a single logical target to redirect to. I'll take care of it tomorrow.

Rick-Anderson · 2019-01-04T00:57:29Z

But don't we eventually need a 2.2 to 3.0 migration doc?

tdykstra · 2019-01-04T01:11:01Z

Not in the fundamentals/logging folder

Rick-Anderson · 2019-01-04T05:13:13Z

In the migrations folder.

tdykstra · 2019-01-04T20:56:17Z

Once I realized the only 3.0 content was for non-ASP.NET Core apps, it no longer made sense to put it in a new ASP.NET Core migration doc, so I ended up with this:

2.1 to 2.2 ASP.NET Core logging content --> ASP.NET Core 2.1 to 2.2 migration doc
2.1 to 2.2 or 3.0 non-ASP.NET Core logging content --> new doc in migration folder, a temporary location until we have a better place for non-ASP.NET Core logging docs.

I had already created the new 2.2 to 3.0 migration doc for #9490 before deciding the logging content didn't fit, so I'm including it as well.

Rick-Anderson · 2019-01-04T22:21:11Z

aspnetcore/migration/22-to-30.md

+
+* Remove the `<PackageReference>` to `Microsoft.AspNetCore.All` and `Microsoft.AspNetCore.App`.
+
+  **Preview 1 Known Issue** - workaround for NuGet/Home#7342 - projects that do not start with `<Project Sdk="Microsoft.NET.Sdk.Web">` will get compiler or runtime errors due to missing Microsoft.AspNetCore.* assemblies. This is most often the case for test projects and class libraries. The workaround is to add the following to the *.csproj* file.


make a link out of NuGet/Home#7342

Why not a proper WARNING here?

Suggested change

**Preview 1 Known Issue** - workaround for NuGet/Home#7342 - projects that do not start with `<Project Sdk="Microsoft.NET.Sdk.Web">` will get compiler or runtime errors due to missing Microsoft.AspNetCore.* assemblies. This is most often the case for test projects and class libraries. The workaround is to add the following to the *.csproj* file.

> [!WARNING]

> **Preview 1 Known Issue**

>

> Projects that don't start with `<Project Sdk="Microsoft.NET.Sdk.Web">` receive compiler or runtime errors due to missing `Microsoft.AspNetCore.*` assemblies. This is most often the case for test projects and class libraries. The workaround is to add the following to the *.csproj* file:

>

> ```xml

> <ItemGroup>

> <FrameworkReference Include="Microsoft.AspNetCore.App" />

> </ItemGroup>

> ```

>

> For more information, see [Represent FrameworkReferences in NuGet packages and assets files (NuGet/Home #7342)](https://github.com/NuGet/Home/issues/7342).

Rick-Anderson · 2019-01-04T22:22:34Z

aspnetcore/migration/22-to-30.md

+  </ItemGroup>
+  ```
+
+* Update the `Version` on remaining `<PackageReference>` elements for `Microsoft.AspNetCore.*` packages to 3.0.0-preview-18579-0053 (or whatever the number is for the current Preview)


Update the Version on remaining <PackageReference> elements for Microsoft.AspNetCore.* packages to the current preview (for example, 3.0.0-preview-18579-0053).

Rick-Anderson · 2019-01-04T22:24:35Z

aspnetcore/migration/22-to-30.md

+
+* Update the `Version` on remaining `<PackageReference>` elements for `Microsoft.AspNetCore.*` packages to 3.0.0-preview-18579-0053 (or whatever the number is for the current Preview)
+
+  If there is no 3.0 version of a package, the package might have been deprecated in 3.0. Many of these are part of `Microsoft.AspNetCore.App` and don't need to be referenced individually anymore. For a preliminary list of packages no longer produced in 3.0, see https://github.com/aspnet/AspNetCore/issues/3756.


Many of these are part of Microsoft.AspNetCore.App and don't need to be referenced individually anymore~. Better Many of these are part of Microsoft.AspNetCore.App` and should not be referenced individually.

Is there a list of deprecated packages in 3.0?

Is there a list of deprecated packages in 3.0?

dotnet/aspnetcore#3756

Rick-Anderson · 2019-01-04T22:27:23Z

aspnetcore/migration/22-to-30.md

+
+  If there is no 3.0 version of a package, the package might have been deprecated in 3.0. Many of these are part of `Microsoft.AspNetCore.App` and don't need to be referenced individually anymore. For a preliminary list of packages no longer produced in 3.0, see https://github.com/aspnet/AspNetCore/issues/3756.
+
+* Some APIs were removed from Microsoft.AspNetCore.App between 2.x and 3.0. You may need to add `<PackageReference>` items if you're using API from packages listed in https://github.com/aspnet/AspNetCore/issues/3755


Some assemblies were removed from Microsoft.AspNetCore.App between 2.x and 3.0. You may need to add <PackageReference> items if you're using APIs from packages listed in dotnet/aspnetcore#3755

I always include the title in these types of issue links. Suggestion (this is what I use) ...

[Assemblies being removed from Microsoft.AspNetCore.App 3.0 (aspnet/AspNetCore #3755)](https://github.com/dotnet/aspnetcore/issues/3755)

Rick-Anderson · 2019-01-04T22:28:31Z

aspnetcore/migration/22-to-30.md

+
+* Some APIs were removed from Microsoft.AspNetCore.App between 2.x and 3.0. You may need to add `<PackageReference>` items if you're using API from packages listed in https://github.com/aspnet/AspNetCore/issues/3755
+
+  For example, Entity Framework Core and System.Data.SqlClient are no longer part of Microsoft.AspNetCore.App.


I prefer to code-fence packages. They're code in the project file.

@tdykstra can you review my suggestions and apply as appropriate?

... and we pretty much always link to our metapackage topic (with the word "metapackage" in the link) ...

[Microsoft.AspNetCore.App metapackage](xref:fundamentals/metapackage-app)

scottaddie

This reminds me that I need to submit a version selector moniker request for ASP.NET Core 3.0. I'll submit that request right now.

scottaddie · 2019-01-04T23:02:19Z

aspnetcore/includes/net-core-prereqs-vs-3.0.md

@@ -0,0 +1,2 @@
+* [Visual Studio 2017 version 15.9 or later](https://visualstudio.microsoft.com/downloads/) with the **ASP.NET and web development** workload


Use the campaign link to allow tracking:

Suggested change

* [Visual Studio 2017 version 15.9 or later](https://visualstudio.microsoft.com/downloads/) with the **ASP.NET and web development** workload

* [Visual Studio 2017 version 15.9 or later](https://www.visualstudio.com/downloads/?utm_medium=microsoft&utm_source=docs.microsoft.com&utm_campaign=button+cta&utm_content=download+vs2017) with the **ASP.NET and web development** workload

Also, I suspect VS 2019 will be required when 3.0 releases. Do we have an issue to update prereqs accordingly?

Also, I suspect VS 2019 will be required when 3.0 releases. Do we have an issue to update prereqs accordingly?

I don't think we have been creating a dedicated issue for updating prereq includes each release. I would wait until VS 2019 becomes required; that'll be the sort of change that we won't need a reminder to change prereqs for.

scottaddie · 2019-01-04T23:03:30Z

aspnetcore/includes/net-core-prereqs-vs-3.0.md

@@ -0,0 +1,2 @@
+* [Visual Studio 2017 version 15.9 or later](https://visualstudio.microsoft.com/downloads/) with the **ASP.NET and web development** workload
+* [.NET Core SDK 3.0 Preview](https://www.microsoft.com/net/download/all)


Consider future-proofing this text by dropping the "Preview" moniker:

Suggested change

* [.NET Core SDK 3.0 Preview](https://www.microsoft.com/net/download/all)

* [.NET Core SDK 3.0](https://www.microsoft.com/net/download/all)

scottaddie · 2019-01-04T23:05:08Z

aspnetcore/migration/21-to-22.md

@@ -142,6 +142,77 @@ Change the `FROM` lines in your *Dockerfile* to use the new image tags in the pr

 Visual Studio's **Auto build on browser request** experience doesn't function with the [IIS in-process hosting model](xref:fundamentals/servers/index#in-process-hosting-model). You must manually rebuild the project when using in-process hosting. Improvements to this experience are planned for a future release of Visual Studio.

+## Update logging code
+
+* Move logging provider initialization to `ConfigureServices`.


Suggested change

* Move logging provider initialization to `ConfigureServices`.

* Move logging provider initialization to `Startup.ConfigureServices`.

scottaddie · 2019-01-04T23:05:30Z

aspnetcore/migration/21-to-22.md

+  }
+  ```
+
+* Change filtering to use `AddLogging` builder.


Suggested change

* Change filtering to use `AddLogging` builder.

* Change filtering to use the `AddLogging` builder.

scottaddie · 2019-01-04T23:05:53Z

aspnetcore/migration/21-to-22.md

+  }
+  ```
+
+* Change configuration loading to use `AddLogging` builder.


Suggested change

* Change configuration loading to use `AddLogging` builder.

* Change configuration loading to use the `AddLogging` builder.

scottaddie · 2019-01-04T23:08:46Z

aspnetcore/migration/22-to-30.md

+
+  If there is no 3.0 version of a package, the package might have been deprecated in 3.0. Many of these are part of `Microsoft.AspNetCore.App` and should not be referenced individually anymore. For a preliminary list of packages no longer produced in 3.0, see [aspnet/AspNetCore #3756](https://github.com/aspnet/AspNetCore/issues/3756).
+
+* Some assemblies were removed from Microsoft.AspNetCore.App between 2.x and 3.0. You may need to add `<PackageReference>` items if you're using APIs from packages listed in [aspnet/AspNetCore #3755](https://github.com/aspnet/AspNetCore/issues/3755)


Suggested change

* Some assemblies were removed from Microsoft.AspNetCore.App between 2.x and 3.0. You may need to add `<PackageReference>` items if you're using APIs from packages listed in [aspnet/AspNetCore #3755](https://github.com/aspnet/AspNetCore/issues/3755)

* Some assemblies were removed from `Microsoft.AspNetCore.App` between 2.x and 3.0. You may need to add `<PackageReference>` items if you're using APIs from packages listed in [aspnet/AspNetCore #3755](https://github.com/aspnet/AspNetCore/issues/3755)

scottaddie · 2019-01-04T23:09:04Z

aspnetcore/migration/22-to-30.md

+
+* Some assemblies were removed from Microsoft.AspNetCore.App between 2.x and 3.0. You may need to add `<PackageReference>` items if you're using APIs from packages listed in [aspnet/AspNetCore #3755](https://github.com/aspnet/AspNetCore/issues/3755)
+
+  For example, `Microsoft.EntityFrameworkCore` and `System.Data.SqlClient` are no longer part of Microsoft.AspNetCore.App.


Suggested change

For example, `Microsoft.EntityFrameworkCore` and `System.Data.SqlClient` are no longer part of Microsoft.AspNetCore.App.

For example, `Microsoft.EntityFrameworkCore` and `System.Data.SqlClient` are no longer part of `Microsoft.AspNetCore.App`.

scottaddie · 2019-01-04T23:09:17Z

aspnetcore/migration/22-to-30.md

+
+  For example, `Microsoft.EntityFrameworkCore` and `System.Data.SqlClient` are no longer part of Microsoft.AspNetCore.App.
+
+  **Preview 1 Known Issue** - the list of assemblies shipping in `Microsoft.AspNetCore.App` has not been finalized yet and will change before 3.0 RTM.


Suggested change

**Preview 1 Known Issue** - the list of assemblies shipping in `Microsoft.AspNetCore.App` has not been finalized yet and will change before 3.0 RTM.

**Preview 1 Known Issue** - the list of assemblies shipping in `Microsoft.AspNetCore.App` hasn't been finalized yet and will change before 3.0 RTM.

scottaddie · 2019-01-04T23:09:51Z

aspnetcore/migration/Logging-nonaspnetcore.md

+
+## 2.1 to 3.0
+
+In 3.0 use `LoggingFactory.Create`.


Suggested change

In 3.0 use `LoggingFactory.Create`.

In 3.0, use `LoggingFactory.Create`.

scottaddie · 2019-01-04T23:10:06Z

aspnetcore/toc.md

@@ -392,6 +392,7 @@
 ## [Use a file watcher](xref:tutorials/dotnet-watch)

 # Migration
+## [2.2 to 3.0 ](xref:migration/22-to-30)


Suggested change

## [2.2 to 3.0 ](xref:migration/22-to-30)

## [2.2 to 3.0](xref:migration/22-to-30)

guardrex · 2019-01-04T22:29:53Z

aspnetcore/includes/net-core-prereqs-mac-3.0.md

@@ -0,0 +1,2 @@
+* [Visual Studio for Mac version 7.7 or later](https://www.visualstudio.com/downloads/)


I'd prefer to land on https://visualstudio.microsoft.com/vs/mac/ than that downloads page. Seems more focused and friendly for Mac users.

guardrex · 2019-01-04T22:32:54Z

aspnetcore/includes/net-core-prereqs-vs-3.0.md

@@ -0,0 +1,2 @@
+* [Visual Studio 2017 version 15.9 or later](https://visualstudio.microsoft.com/downloads/) with the **ASP.NET and web development** workload
+* [.NET Core SDK 3.0 Preview](https://www.microsoft.com/net/download/all)


Since this link is tied directly to the 3.0 preview, it could go directly there 👉 https://dotnet.microsoft.com/download/dotnet-core/3.0

Otherwise, this link (as you have it, if you keep it) redirects to 👉 https://dotnet.microsoft.com/download/archives

guardrex · 2019-01-04T22:33:59Z

aspnetcore/includes/net-core-prereqs-all-3.0.md

+
+[!INCLUDE[](~/includes/net-core-prereqs-mac-3.0.md)]
+
+---


Maybe I'm missing something, but no CLI tab with a CLI INCLUDE?

I'm following what we have for 2.2. Tabs are VS, VSC, VSMac.

# [.NET Core CLI](#tab/netcore-cli)

guardrex · 2019-01-04T22:35:06Z

aspnetcore/includes/net-core-prereqs-vsc-3.0.md

@@ -0,0 +1,3 @@
+* [Visual Studio Code](https://code.visualstudio.com/download)


As before, I personally would prefer to hit the nice looking main product page ... it's simple enough to download directly from there.

https://code.visualstudio.com/

guardrex · 2019-01-04T22:35:59Z

aspnetcore/migration/21-to-22.md

@@ -142,6 +142,77 @@ Change the `FROM` lines in your *Dockerfile* to use the new image tags in the pr

 Visual Studio's **Auto build on browser request** experience doesn't function with the [IIS in-process hosting model](xref:fundamentals/servers/index#in-process-hosting-model). You must manually rebuild the project when using in-process hosting. Improvements to this experience are planned for a future release of Visual Studio.

+## Update logging code
+
+* Move logging provider initialization to `ConfigureServices`.


Suggested change

* Move logging provider initialization to `ConfigureServices`.

* Move logging provider initialization to `Startup.ConfigureServices`.

guardrex · 2019-01-04T23:06:02Z

aspnetcore/migration/Logging-nonaspnetcore.md

+ms.date: 01/04/2019
+uid: migration/logging-nonaspnetcore
+---
+


We haven't been putting a blank line here.

Blank line ... I actually went thru ages ago and made this consistent. Recommend that we don't put a blank line under the metadata or that we set up a PR to do it for every topic. My obsessive-compulsive disorder is showing! 😄 lol

guardrex · 2019-01-04T23:09:49Z

aspnetcore/migration/Logging-nonaspnetcore.md

+
+2.1 example:
+
+``` C#


Suggested change

``` C#

```csharp

guardrex · 2019-01-04T23:10:00Z

aspnetcore/migration/Logging-nonaspnetcore.md

+
+2.2 example:
+
+``` C#


Suggested change

``` C#

```csharp

guardrex · 2019-01-04T23:10:25Z

aspnetcore/migration/Logging-nonaspnetcore.md

+
+2.1 example:
+
+``` C#


Suggested change

``` C#

```csharp

guardrex · 2019-01-04T23:10:31Z

aspnetcore/migration/Logging-nonaspnetcore.md

+
+3.0 example:
+
+``` C#


Suggested change

``` C#

```csharp

guardrex · 2019-01-05T00:12:21Z

@tdykstra Another commit coming? ... there are still "C#" code language markers and here's the tab for the CLI if you want to create (or use an existing) INCLUDE ...

# [.NET Core CLI](#tab/netcore-cli)

tdykstra · 2019-01-05T00:25:11Z

@guardrex On the tabs I'll stick with what we're doing for 2.2. VSC and Mac use the CLI.

guardrex

Remaining remarks are nits.

guardrex · 2019-01-05T00:26:27Z

aspnetcore/migration/22-to-30.md

+  <TargetFramework>netcoreapp3.0</TargetFramework>
+  ```
+
+* Remove any `<PackageReference>` to [Microsoft.AspNetCore.All](xref:fundamentals/metapackage)` or [Microsoft.AspNetCore.App](xref:fundamentals/metapackage-app).


AFAIK (without much discussion on it), Rick, Scott, and I adopted a pattern while you were away. The links to the metapackage topics will say "metapackage" in the link, so I suggest (and there's a stray backtick there, too) ...

Suggested change

* Remove any `<PackageReference>` to [Microsoft.AspNetCore.All](xref:fundamentals/metapackage)` or [Microsoft.AspNetCore.App](xref:fundamentals/metapackage-app).

* Remove any `<PackageReference>` to [Microsoft.AspNetCore.All metapackage](xref:fundamentals/metapackage) or [Microsoft.AspNetCore.App metapackage](xref:fundamentals/metapackage-app).

guardrex · 2019-01-05T00:27:16Z

aspnetcore/migration/22-to-30.md

+
+* Remove any `<PackageReference>` to [Microsoft.AspNetCore.All](xref:fundamentals/metapackage)` or [Microsoft.AspNetCore.App](xref:fundamentals/metapackage-app).
+
+  **Preview 1 Known Issue** - workaround for [NuGet/Home #7342](https://github.com/NuGet/Home/issues/7342) - projects that don't start with `<Project Sdk="Microsoft.NET.Sdk.Web">` will get compiler or runtime errors due to missing `Microsoft.AspNetCore.*` assemblies. This is most often the case for test projects and class libraries. The workaround is to add the following to the *.csproj* file.


ugh ... imo, this doesn't look good and the future tense isn't necessary ... but ok.

guardrex · 2019-01-05T00:28:09Z

aspnetcore/migration/22-to-30.md

+
+  For example, `Microsoft.EntityFrameworkCore` and `System.Data.SqlClient` are no longer part of `Microsoft.AspNetCore.App`.
+
+  **Preview 1 Known Issue** - the list of assemblies shipping in `Microsoft.AspNetCore.App` hasn't been finalized yet and will change before 3.0 RTM.


guardrex · 2019-01-05T00:29:39Z

aspnetcore/migration/Logging-nonaspnetcore.md

+ms.date: 01/04/2019
+uid: migration/logging-nonaspnetcore
+---
+


Blank line ... I actually went thru ages ago and made this consistent. Recommend that we don't put a blank line under the metadata or that we set up a PR to do it for every topic. My obsessive-compulsive disorder is showing! 😄 lol

guardrex · 2019-01-05T00:36:15Z

VSC and Mac use the CLI

I hope you'll confer tho on that point. IMO, it would be better to always have all of the tabs. There are devs who like CLI things. It's not obvious to those devs what these IDEs are using. Anyway ... it's just a nit.

tdykstra · 2019-01-05T00:49:35Z

@guardrex I addressed some of the nits, though not quite exactly the way you had in mind. 😄

I hope you'll confer tho on that point.

Will do

pakrym added 3 commits December 27, 2018 11:02

Add logging 2.1 to 2.2/3.0 migration guide

d2f1e3a

Headings

44e4fc4

C#

3d67742

pakrym requested a review from guardrex December 27, 2018 19:12

guardrex removed their request for review December 28, 2018 22:19

tdykstra added 2 commits January 4, 2019 12:28

move to different files

321467c

proofread fixes

7a5f6b3

tdykstra requested review from scottaddie, Rick-Anderson and guardrex January 4, 2019 20:56

Rick-Anderson approved these changes Jan 4, 2019

View reviewed changes

feedback

8fb5503

scottaddie reviewed Jan 4, 2019

View reviewed changes

guardrex requested changes Jan 4, 2019

View reviewed changes

tdykstra added 2 commits January 4, 2019 15:47

guardrex feedback

ad1f438

scottaddie feedback

2cfd8bd

some feedback missed earlier

215b36d

guardrex approved these changes Jan 5, 2019

View reviewed changes

more feedback

e701d8d

tdykstra merged commit 86e897d into master Jan 5, 2019

delete-merged-branch bot deleted the pakrym/21-to-22-30-log branch January 5, 2019 01:03


		* Remove the `<PackageReference>` to `Microsoft.AspNetCore.All` and `Microsoft.AspNetCore.App`.

		Preview 1 Known Issue - workaround for NuGet/Home#7342 - projects that do not start with `<Project Sdk="Microsoft.NET.Sdk.Web">` will get compiler or runtime errors due to missing Microsoft.AspNetCore.* assemblies. This is most often the case for test projects and class libraries. The workaround is to add the following to the .csproj file.

-  **Preview 1 Known Issue** - workaround for NuGet/Home#7342 - projects that do not start with `<Project Sdk="Microsoft.NET.Sdk.Web">` will get compiler or runtime errors due to missing Microsoft.AspNetCore.* assemblies. This is most often the case for test projects and class libraries. The workaround is to add the following to the *.csproj* file.
+> [!WARNING]
+> **Preview 1 Known Issue**
+>
+> Projects that don't start with `<Project Sdk="Microsoft.NET.Sdk.Web">` receive compiler or runtime errors due to missing `Microsoft.AspNetCore.*` assemblies. This is most often the case for test projects and class libraries. The workaround is to add the following to the *.csproj* file:
+>
+> ```xml
+> <ItemGroup>
+>   <FrameworkReference Include="Microsoft.AspNetCore.App" />
+> </ItemGroup>
+> ```
+>
+> For more information, see [Represent FrameworkReferences in NuGet packages and assets files (NuGet/Home #7342)](https://github.com/NuGet/Home/issues/7342).


		* Update the `Version` on remaining `<PackageReference>` elements for `Microsoft.AspNetCore.*` packages to 3.0.0-preview-18579-0053 (or whatever the number is for the current Preview)

		If there is no 3.0 version of a package, the package might have been deprecated in 3.0. Many of these are part of `Microsoft.AspNetCore.App` and don't need to be referenced individually anymore. For a preliminary list of packages no longer produced in 3.0, see https://github.com/aspnet/AspNetCore/issues/3756.


		If there is no 3.0 version of a package, the package might have been deprecated in 3.0. Many of these are part of `Microsoft.AspNetCore.App` and don't need to be referenced individually anymore. For a preliminary list of packages no longer produced in 3.0, see https://github.com/aspnet/AspNetCore/issues/3756.

		* Some APIs were removed from Microsoft.AspNetCore.App between 2.x and 3.0. You may need to add `<PackageReference>` items if you're using API from packages listed in https://github.com/aspnet/AspNetCore/issues/3755


		* Some APIs were removed from Microsoft.AspNetCore.App between 2.x and 3.0. You may need to add `<PackageReference>` items if you're using API from packages listed in https://github.com/aspnet/AspNetCore/issues/3755

		For example, Entity Framework Core and System.Data.SqlClient are no longer part of Microsoft.AspNetCore.App.

		@@ -0,0 +1,2 @@
		* [Visual Studio 2017 version 15.9 or later](https://visualstudio.microsoft.com/downloads/) with the ASP.NET and web development workload

		@@ -0,0 +1,2 @@
		* [Visual Studio 2017 version 15.9 or later](https://visualstudio.microsoft.com/downloads/) with the ASP.NET and web development workload
		* [.NET Core SDK 3.0 Preview](https://www.microsoft.com/net/download/all)

	* [.NET Core SDK 3.0 Preview](https://www.microsoft.com/net/download/all)
	* [.NET Core SDK 3.0](https://www.microsoft.com/net/download/all)

	* Move logging provider initialization to `ConfigureServices`.
	* Move logging provider initialization to `Startup.ConfigureServices`.

	* Change filtering to use `AddLogging` builder.
	* Change filtering to use the `AddLogging` builder.

	* Change configuration loading to use `AddLogging` builder.
	* Change configuration loading to use the `AddLogging` builder.


		If there is no 3.0 version of a package, the package might have been deprecated in 3.0. Many of these are part of `Microsoft.AspNetCore.App` and should not be referenced individually anymore. For a preliminary list of packages no longer produced in 3.0, see [aspnet/AspNetCore #3756](https://github.com/aspnet/AspNetCore/issues/3756).

		* Some assemblies were removed from Microsoft.AspNetCore.App between 2.x and 3.0. You may need to add `<PackageReference>` items if you're using APIs from packages listed in [aspnet/AspNetCore #3755](https://github.com/aspnet/AspNetCore/issues/3755)

	* Some assemblies were removed from Microsoft.AspNetCore.App between 2.x and 3.0. You may need to add `<PackageReference>` items if you're using APIs from packages listed in [aspnet/AspNetCore #3755](https://github.com/aspnet/AspNetCore/issues/3755)
	* Some assemblies were removed from `Microsoft.AspNetCore.App` between 2.x and 3.0. You may need to add `<PackageReference>` items if you're using APIs from packages listed in [aspnet/AspNetCore #3755](https://github.com/aspnet/AspNetCore/issues/3755)


		* Some assemblies were removed from Microsoft.AspNetCore.App between 2.x and 3.0. You may need to add `<PackageReference>` items if you're using APIs from packages listed in [aspnet/AspNetCore #3755](https://github.com/aspnet/AspNetCore/issues/3755)

		For example, `Microsoft.EntityFrameworkCore` and `System.Data.SqlClient` are no longer part of Microsoft.AspNetCore.App.


		For example, `Microsoft.EntityFrameworkCore` and `System.Data.SqlClient` are no longer part of Microsoft.AspNetCore.App.

		Preview 1 Known Issue - the list of assemblies shipping in `Microsoft.AspNetCore.App` has not been finalized yet and will change before 3.0 RTM.

	In 3.0 use `LoggingFactory.Create`.
	In 3.0, use `LoggingFactory.Create`.

	## [2.2 to 3.0 ](xref:migration/22-to-30)
	## [2.2 to 3.0](xref:migration/22-to-30)

		@@ -0,0 +1,2 @@
		* [Visual Studio for Mac version 7.7 or later](https://www.visualstudio.com/downloads/)

		@@ -0,0 +1,3 @@
		* [Visual Studio Code](https://code.visualstudio.com/download)

	* Remove any `<PackageReference>` to [Microsoft.AspNetCore.All](xref:fundamentals/metapackage)` or [Microsoft.AspNetCore.App](xref:fundamentals/metapackage-app).
	* Remove any `<PackageReference>` to [Microsoft.AspNetCore.All metapackage](xref:fundamentals/metapackage) or [Microsoft.AspNetCore.App metapackage](xref:fundamentals/metapackage-app).

Add logging 2.1 to 2.2/3.0 migration guide #10122

Add logging 2.1 to 2.2/3.0 migration guide #10122

Conversation

pakrym commented Dec 27, 2018 • edited by tdykstra Loading

pakrym commented Dec 27, 2018

guardrex commented Dec 27, 2018 • edited Loading

tdykstra commented Dec 28, 2018

pakrym commented Dec 28, 2018

pakrym commented Dec 28, 2018

tdykstra commented Dec 28, 2018

Rick-Anderson commented Dec 28, 2018

tdykstra commented Dec 28, 2018

pakrym commented Dec 28, 2018

tdykstra commented Dec 28, 2018

tdykstra commented Dec 28, 2018

pakrym commented Dec 28, 2018

tdykstra commented Dec 28, 2018

guardrex commented Dec 29, 2018

Rick-Anderson commented Jan 3, 2019

tdykstra commented Jan 4, 2019

Rick-Anderson commented Jan 4, 2019

tdykstra commented Jan 4, 2019

Rick-Anderson commented Jan 4, 2019

tdykstra commented Jan 4, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scottaddie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guardrex Jan 4, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guardrex commented Jan 5, 2019 • edited Loading

tdykstra commented Jan 5, 2019

guardrex left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guardrex commented Jan 5, 2019

tdykstra commented Jan 5, 2019

pakrym commented Dec 27, 2018 •

edited by tdykstra

Loading

guardrex commented Dec 27, 2018 •

edited

Loading

guardrex Jan 4, 2019 •

edited

Loading

guardrex commented Jan 5, 2019 •

edited

Loading