Only build sequentially.

Author: timcassell

src/BenchmarkDotNet/Running/BenchmarkRunnerClean.cs

@@ -76,7 +76,7 @@ internal static Summary[] Run(BenchmarkRunInfo[] benchmarkRunInfos)
                 var globalChronometer = Chronometer.Start();
 
                 var buildPartitions = BenchmarkPartitioner.CreateForBuild(supportedBenchmarks, resolver);
-                var buildResults = BuildInParallel(compositeLogger, rootArtifactsFolderPath, buildPartitions, in globalChronometer);
+                var buildResults = Build(compositeLogger, rootArtifactsFolderPath, buildPartitions, in globalChronometer);
                 var allBuildsHaveFailed = buildResults.Values.All(buildResult => !buildResult.IsBuildSuccess);
 
                 try
@@ -347,35 +347,19 @@ private static ImmutableArray<ValidationError> Validate(params BenchmarkRunInfo[
             return validationErrors.ToImmutableArray();
         }
 
-        private static Dictionary<BuildPartition, BuildResult> BuildInParallel(ILogger logger, string rootArtifactsFolderPath, BuildPartition[] buildPartitions, in StartedClock globalChronometer)
+        private static Dictionary<BuildPartition, BuildResult> Build(ILogger logger, string rootArtifactsFolderPath, BuildPartition[] buildPartitions, in StartedClock globalChronometer)
         {
-            logger.WriteLineHeader($"// ***** Building {buildPartitions.Length} exe(s) in Parallel: Start   *****");
+            logger.WriteLineHeader($"// ***** Building {buildPartitions.Length} exe(s): Start   *****");
 
-            var buildLogger = buildPartitions.Length == 1 ? logger : NullLogger.Instance; // when we have just one partition we can print to std out
-
-            var beforeParallelBuild = globalChronometer.GetElapsed();
+            var beforeBuild = globalChronometer.GetElapsed();
 
             var buildResults = buildPartitions
-                .AsParallel()
-                .Select(buildPartition => (buildPartition, buildResult: Build(buildPartition, rootArtifactsFolderPath, buildLogger)))
+                .Select(buildPartition => (buildPartition, buildResult: Build(buildPartition, rootArtifactsFolderPath, logger)))
                 .ToDictionary(result => result.buildPartition, result => result.buildResult);
 
-            var afterParallelBuild = globalChronometer.GetElapsed();
-
-            logger.WriteLineHeader($"// ***** Done, took {GetFormattedDifference(beforeParallelBuild, afterParallelBuild)}   *****");
-
-            if (buildPartitions.Length <= 1 || !buildResults.Values.Any(result => result.IsGenerateSuccess && !result.IsBuildSuccess))
-                return buildResults;
-
-            logger.WriteLineHeader("// ***** Failed to build in Parallel, switching to sequential build   *****");
-
-            foreach (var buildPartition in buildPartitions)
-                if (buildResults[buildPartition].IsGenerateSuccess && !buildResults[buildPartition].IsBuildSuccess && !buildResults[buildPartition].TryToExplainFailureReason(out string _))
-                    buildResults[buildPartition] = Build(buildPartition, rootArtifactsFolderPath, buildLogger);
-
-            var afterSequentialBuild = globalChronometer.GetElapsed();
+            var afterBuild = globalChronometer.GetElapsed();
 
-            logger.WriteLineHeader($"// ***** Done, took {GetFormattedDifference(afterParallelBuild, afterSequentialBuild)}   *****");
+            logger.WriteLineHeader($"// ***** Done, took {GetFormattedDifference(beforeBuild, afterBuild)}   *****");
 
             return buildResults;