Simplify GetHashCode() (#2177)

YegorStepanov · web-flow · commit 28a8e78a721d · 2022-11-03T12:37:33.000+04:00
* Add package for netstandart2.0 * Simplify HashCode * Fix a bug: job.Infrastructure.Arguments is an array, so compare its values * Remove outdated suppressor * Revert "Fix a bug: job.Infrastructure.Arguments is an array, so compare its values" This reverts commit 2b5b6b4. * Revert "Simplify HashCode" This reverts commit 681ceab. * Revert "Add package for netstandart2.0" This reverts commit 8f0e2e4. * Mimic System.HashCode * Simplify GetHashCode() * Remove redundant * Fix bugs * Reorder * fix a bug: compare Argument by TextRepresentation, not by reference * Simplify * Add missing HashCode API * Suppress inspection
diff --git a/src/BenchmarkDotNet/Analysers/Conclusion.cs b/src/BenchmarkDotNet/Analysers/Conclusion.cs
@@ -64,15 +64,9 @@ public override bool Equals(object obj)
 
         public override int GetHashCode()
         {
-            unchecked
-            {
-                int hashCode = AnalyserId.GetHashCode();
-                hashCode = (hashCode * 397) ^ (int) Kind;
-                hashCode = Mergeable
-                           ? (hashCode * 397) ^ Message.GetHashCode()
-                           : (hashCode * 397) ^ Report?.ToString().GetHashCode() ?? string.Empty.GetHashCode();
-                return hashCode;
-            }
+            return Mergeable
+                ? HashCode.Combine(AnalyserId, Kind, Message)
+                : HashCode.Combine(AnalyserId, Kind, Report?.ToString());
         }
     }
 }
diff --git a/src/BenchmarkDotNet/Analysers/HideColumnsAnalyser.cs b/src/BenchmarkDotNet/Analysers/HideColumnsAnalyser.cs
@@ -21,7 +21,7 @@ protected override IEnumerable<Conclusion> AnalyseSummary(Summary summary)
             var columnNames = string.Join(", ", hiddenColumns.Select(c => c.OriginalColumn.ColumnName));
 
             var message = $"Hidden columns: {columnNames}";
-            yield return Conclusion.CreateHint(Id, message);
+            yield return CreateHint(message);
         }
     }
 }
diff --git a/src/BenchmarkDotNet/Columns/SizeUnit.cs b/src/BenchmarkDotNet/Columns/SizeUnit.cs
@@ -66,19 +66,10 @@ public override bool Equals(object obj)
             return Equals((SizeUnit) obj);
         }
 
-        public override int GetHashCode()
-        {
-            unchecked
-            {
-                int hashCode = (Name != null ? Name.GetHashCode() : 0);
-                hashCode = (hashCode * 397) ^ (Description != null ? Description.GetHashCode() : 0);
-                hashCode = (hashCode * 397) ^ ByteAmount.GetHashCode();
-                return hashCode;
-            }
-        }
+        public override int GetHashCode() => HashCode.Combine(Name, Description, ByteAmount);
 
         public static bool operator ==(SizeUnit left, SizeUnit right) => Equals(left, right);
 
         public static bool operator !=(SizeUnit left, SizeUnit right) => !Equals(left, right);
     }
-}
+}
diff --git a/src/BenchmarkDotNet/Disassemblers/ClrMdV2Disassembler.cs b/src/BenchmarkDotNet/Disassemblers/ClrMdV2Disassembler.cs
@@ -327,7 +327,7 @@ public bool Equals(Sharp x, Sharp y)
                 return x.FilePath == y.FilePath && x.LineNumber == y.LineNumber;
             }
 
-            public int GetHashCode(Sharp obj) => obj.FilePath.GetHashCode() ^ obj.LineNumber;
+            public int GetHashCode(Sharp obj) => HashCode.Combine(obj.FilePath, obj.LineNumber);
         }
     }
-}
+}
diff --git a/src/BenchmarkDotNet/Engines/GcStats.cs b/src/BenchmarkDotNet/Engines/GcStats.cs
@@ -223,17 +223,6 @@ private static long CalculateAllocationQuantumSize()
 
         public override bool Equals(object obj) => obj is GcStats other && Equals(other);
 
-        public override int GetHashCode()
-        {
-            unchecked
-            {
-                int hashCode = Gen0Collections;
-                hashCode = (hashCode * 397) ^ Gen1Collections;
-                hashCode = (hashCode * 397) ^ Gen2Collections;
-                hashCode = (hashCode * 397) ^ AllocatedBytes.GetHashCode();
-                hashCode = (hashCode * 397) ^ TotalOperations.GetHashCode();
-                return hashCode;
-            }
-        }
+        public override int GetHashCode() => HashCode.Combine(Gen0Collections, Gen1Collections, Gen2Collections, AllocatedBytes, TotalOperations);
     }
 }
diff --git a/src/BenchmarkDotNet/Engines/ThreadingStats.cs b/src/BenchmarkDotNet/Engines/ThreadingStats.cs
@@ -86,15 +86,6 @@ private static Func<long> CreateGetterDelegate(Type type, string propertyName)
 
         public override bool Equals(object obj) => obj is ThreadingStats other && Equals(other);
 
-        public override int GetHashCode()
-        {
-            unchecked
-            {
-                int hashCode = CompletedWorkItemCount.GetHashCode();
-                hashCode = (hashCode * 397) ^ LockContentionCount.GetHashCode();
-                hashCode = (hashCode * 397) ^ TotalOperations.GetHashCode();
-                return hashCode;
-            }
-        }
+        public override int GetHashCode() => HashCode.Combine(CompletedWorkItemCount, LockContentionCount, TotalOperations);
     }
 }
diff --git a/src/BenchmarkDotNet/Environments/BenchmarkEnvironmentInfo.cs b/src/BenchmarkDotNet/Environments/BenchmarkEnvironmentInfo.cs
@@ -70,7 +70,6 @@ internal string GetRuntimeInfo()
             return $"{RuntimeVersion}, {Architecture} {jitInfo}";
         }
 
-        [SuppressMessage("ReSharper", "UnusedMember.Global")] // TODO: should be used or removed
         public static IEnumerable<ValidationError> Validate(Job job)
         {
             if (job.Environment.Jit == Jit.RyuJit && !RuntimeInformation.HasRyuJit())
diff --git a/src/BenchmarkDotNet/Environments/Runtimes/ClrRuntime.cs b/src/BenchmarkDotNet/Environments/Runtimes/ClrRuntime.cs
@@ -40,7 +40,7 @@ public static ClrRuntime CreateForLocalFullNetFrameworkBuild(string version)
 
         public bool Equals(ClrRuntime other) => other != null && base.Equals(other) && Version == other.Version;
 
-        public override int GetHashCode() => base.GetHashCode() ^ (Version?.GetHashCode() ?? 0);
+        public override int GetHashCode() => HashCode.Combine(base.GetHashCode(), Version);
 
         internal static ClrRuntime GetCurrentVersion()
         {
@@ -69,4 +69,4 @@ internal static ClrRuntime GetCurrentVersion()
             }
         }
     }
-}
+}
diff --git a/src/BenchmarkDotNet/Environments/Runtimes/MonoAotLLVMRuntime.cs b/src/BenchmarkDotNet/Environments/Runtimes/MonoAotLLVMRuntime.cs
@@ -44,6 +44,6 @@ public bool Equals(MonoAotLLVMRuntime other)
             => other != null && base.Equals(other) && other.AOTCompilerPath == AOTCompilerPath;
 
         public override int GetHashCode()
-            => base.GetHashCode() ^ AOTCompilerPath.GetHashCode();
+            => HashCode.Combine(base.GetHashCode(), AOTCompilerPath);
     }
-}
+}
diff --git a/src/BenchmarkDotNet/Environments/Runtimes/MonoRuntime.cs b/src/BenchmarkDotNet/Environments/Runtimes/MonoRuntime.cs
@@ -41,6 +41,6 @@ public bool Equals(MonoRuntime other)
             => base.Equals(other) && Name == other?.Name && CustomPath == other?.CustomPath && AotArgs == other?.AotArgs && MonoBclPath == other?.MonoBclPath;
 
         public override int GetHashCode()
-            => base.GetHashCode() ^ Name.GetHashCode() ^ (CustomPath?.GetHashCode() ?? 0) ^ (AotArgs?.GetHashCode() ?? 0) ^ (MonoBclPath?.GetHashCode() ?? 0);
+            => HashCode.Combine(base.GetHashCode(), Name, CustomPath, AotArgs, MonoBclPath);
     }
-}
+}
diff --git a/src/BenchmarkDotNet/Environments/Runtimes/Runtime.cs b/src/BenchmarkDotNet/Environments/Runtimes/Runtime.cs
@@ -41,6 +41,6 @@ public bool Equals(Runtime other)
 
         public override bool Equals(object obj) => obj is Runtime other && Equals(other);
 
-        public override int GetHashCode() => Name.GetHashCode() ^ (int)RuntimeMoniker ^ MsBuildMoniker.GetHashCode();
+        public override int GetHashCode() => HashCode.Combine(Name, MsBuildMoniker, RuntimeMoniker);
     }
-}
+}
diff --git a/src/BenchmarkDotNet/Environments/Runtimes/WasmRuntime.cs b/src/BenchmarkDotNet/Environments/Runtimes/WasmRuntime.cs
@@ -46,6 +46,6 @@ public bool Equals(WasmRuntime other)
             => other != null && base.Equals(other) && other.JavaScriptEngine == JavaScriptEngine && other.JavaScriptEngineArguments == JavaScriptEngineArguments && other.Aot == Aot;
 
         public override int GetHashCode()
-            => base.GetHashCode() ^ (JavaScriptEngine?.GetHashCode() ?? 0) ^ (JavaScriptEngineArguments?.GetHashCode() ?? 0 ^ Aot.GetHashCode());
+            => HashCode.Combine(base.GetHashCode(), JavaScriptEngine, JavaScriptEngineArguments, Aot);
     }
-}
+}
diff --git a/src/BenchmarkDotNet/Helpers/HashCode.cs b/src/BenchmarkDotNet/Helpers/HashCode.cs
@@ -0,0 +1,140 @@
+﻿using System;
+using System.Collections.Generic;
+using System.ComponentModel;
+using System.Runtime.CompilerServices;
+
+// Mimics System.HashCode, which is missing in NetStandard2.0.
+// Placed in root namespace to avoid ambiguous reference with System.HashCode
+
+// ReSharper disable once CheckNamespace
+namespace BenchmarkDotNet
+{
+    internal struct HashCode
+    {
+        private int hashCode;
+
+        public void Add<T>(T value)
+        {
+            hashCode = Hash(hashCode, value);
+        }
+
+        public void Add<T>(T value, IEqualityComparer<T> comparer)
+        {
+            hashCode = Hash(hashCode, value, comparer);
+        }
+
+        public readonly int ToHashCode() => hashCode;
+
+        public static int Combine<T1>(T1 value1)
+        {
+            int hashCode = 0;
+            hashCode = Hash(hashCode, value1);
+            return hashCode;
+        }
+
+        public static int Combine<T1, T2>(T1 value1, T2 value2)
+        {
+            int hashCode = 0;
+            hashCode = Hash(hashCode, value1);
+            hashCode = Hash(hashCode, value2);
+            return hashCode;
+        }
+
+        public static int Combine<T1, T2, T3>(T1 value1, T2 value2, T3 value3)
+        {
+            int hashCode = 0;
+            hashCode = Hash(hashCode, value1);
+            hashCode = Hash(hashCode, value2);
+            hashCode = Hash(hashCode, value3);
+            return hashCode;
+        }
+
+        public static int Combine<T1, T2, T3, T4>(T1 value1, T2 value2, T3 value3, T4 value4)
+        {
+            int hashCode = 0;
+            hashCode = Hash(hashCode, value1);
+            hashCode = Hash(hashCode, value2);
+            hashCode = Hash(hashCode, value3);
+            hashCode = Hash(hashCode, value4);
+            return hashCode;
+        }
+
+        public static int Combine<T1, T2, T3, T4, T5>(T1 value1, T2 value2, T3 value3, T4 value4, T5 value5)
+        {
+            int hashCode = 0;
+            hashCode = Hash(hashCode, value1);
+            hashCode = Hash(hashCode, value2);
+            hashCode = Hash(hashCode, value3);
+            hashCode = Hash(hashCode, value4);
+            hashCode = Hash(hashCode, value5);
+            return hashCode;
+        }
+
+        public static int Combine<T1, T2, T3, T4, T5, T6>(T1 value1, T2 value2, T3 value3, T4 value4, T5 value5, T6 value6)
+        {
+            int hashCode = 0;
+            hashCode = Hash(hashCode, value1);
+            hashCode = Hash(hashCode, value2);
+            hashCode = Hash(hashCode, value3);
+            hashCode = Hash(hashCode, value4);
+            hashCode = Hash(hashCode, value5);
+            hashCode = Hash(hashCode, value6);
+            return hashCode;
+        }
+
+        public static int Combine<T1, T2, T3, T4, T5, T6, T7>(T1 value1, T2 value2, T3 value3, T4 value4, T5 value5, T6 value6, T7 value7)
+        {
+            int hashCode = 0;
+            hashCode = Hash(hashCode, value1);
+            hashCode = Hash(hashCode, value2);
+            hashCode = Hash(hashCode, value3);
+            hashCode = Hash(hashCode, value4);
+            hashCode = Hash(hashCode, value5);
+            hashCode = Hash(hashCode, value6);
+            hashCode = Hash(hashCode, value7);
+            return hashCode;
+        }
+
+        public static int Combine<T1, T2, T3, T4, T5, T6, T7, T8>(T1 value1, T2 value2, T3 value3, T4 value4, T5 value5, T6 value6, T7 value7, T8 value8)
+        {
+            int hashCode = 0;
+            hashCode = Hash(hashCode, value1);
+            hashCode = Hash(hashCode, value2);
+            hashCode = Hash(hashCode, value3);
+            hashCode = Hash(hashCode, value4);
+            hashCode = Hash(hashCode, value5);
+            hashCode = Hash(hashCode, value6);
+            hashCode = Hash(hashCode, value7);
+            hashCode = Hash(hashCode, value8);
+            return hashCode;
+        }
+
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
+        private static int Hash<T>(int hashCode, T value)
+        {
+            unchecked
+            {
+                return (hashCode * 397) ^ (value?.GetHashCode() ?? 0);
+            }
+        }
+
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
+        private static int Hash<T>(int hashCode, T value, IEqualityComparer<T> comparer)
+        {
+            unchecked
+            {
+                return (hashCode * 397) ^ (value is null ? 0 : (comparer?.GetHashCode(value) ?? value.GetHashCode()));
+            }
+        }
+
+#pragma warning disable CS0809 // Obsolete member 'HashCode.GetHashCode()' overrides non-obsolete member 'object.GetHashCode()'
+        [Obsolete("HashCode is a mutable struct and should not be compared with other HashCodes. Use ToHashCode to retrieve the computed hash code.", error: true)]
+        [EditorBrowsable(EditorBrowsableState.Never)]
+        public override int GetHashCode() => throw new NotSupportedException();
+
+        [Obsolete("HashCode is a mutable struct and should not be compared with other HashCodes.", error: true)]
+        [EditorBrowsable(EditorBrowsableState.Never)]
+        public override bool Equals(object obj) => throw new NotSupportedException();
+#pragma warning restore CS0809 // Obsolete member 'HashCode.GetHashCode()' overrides non-obsolete member 'object.GetHashCode()'
+    }
+}
diff --git a/src/BenchmarkDotNet/Jobs/Argument.cs b/src/BenchmarkDotNet/Jobs/Argument.cs
@@ -3,12 +3,28 @@
 
 namespace BenchmarkDotNet.Jobs
 {
-    public abstract class Argument
+    public abstract class Argument: IEquatable<Argument>
     {
-        [PublicAPI] public string TextRepresentation { get; protected set; }
+        [PublicAPI] public string TextRepresentation { get; }
+
+        protected Argument(string value)
+        {
+            TextRepresentation = value;
+        }
 
         // CharacteristicPresenters call ToString(), this is why we need this override
         public override string ToString() => TextRepresentation;
+
+        public bool Equals(Argument other)
+        {
+            if (ReferenceEquals(null, other)) return false;
+            if (ReferenceEquals(this, other)) return true;
+            return TextRepresentation == other.TextRepresentation;
+        }
+
+        public override bool Equals(object obj) => Equals(obj as Argument);
+
+        public override int GetHashCode() => HashCode.Combine(TextRepresentation);
     }
 
     /// <summary>
@@ -17,12 +33,10 @@ public abstract class Argument
     /// </summary>
     public class MonoArgument : Argument
     {
-        public MonoArgument(string value)
+        public MonoArgument(string value) : base(value)
         {
             if (value == "--llvm" || value == "--nollvm")
                 throw new NotSupportedException("Please use job.Env.Jit to specify Jit in explicit way");
-
-            TextRepresentation = value;
         }
     }
 
@@ -33,6 +47,6 @@ public MonoArgument(string value)
     [PublicAPI]
     public class MsBuildArgument : Argument
     {
-        public MsBuildArgument(string value) => TextRepresentation = value;
+        public MsBuildArgument(string value) : base(value) { }
     }
 }
diff --git a/src/BenchmarkDotNet/Jobs/EnvironmentVariable.cs b/src/BenchmarkDotNet/Jobs/EnvironmentVariable.cs
@@ -33,12 +33,6 @@ public override bool Equals(object obj)
             return Equals((EnvironmentVariable) obj);
         }
 
-        public override int GetHashCode()
-        {
-            unchecked
-            {
-                return (Key.GetHashCode() * 397) ^ Value.GetHashCode();
-            }
-        }
+        public override int GetHashCode() => HashCode.Combine(Key, Value);
     }
 }
diff --git a/src/BenchmarkDotNet/Jobs/GcMode.cs b/src/BenchmarkDotNet/Jobs/GcMode.cs
@@ -123,7 +123,6 @@ public bool Equals(GcMode other)
                 && other.Server == Server;
 
         public override int GetHashCode()
-            => AllowVeryLargeObjects.GetHashCode() ^ Concurrent.GetHashCode() ^ CpuGroups.GetHashCode() ^ Force.GetHashCode() ^ NoAffinitize.GetHashCode() ^
-               RetainVm.GetHashCode() ^ Server.GetHashCode();
+            => HashCode.Combine(AllowVeryLargeObjects, Concurrent, CpuGroups, Force, NoAffinitize, RetainVm, Server);
     }
 }
diff --git a/src/BenchmarkDotNet/Jobs/NugetReference.cs b/src/BenchmarkDotNet/Jobs/NugetReference.cs
@@ -43,10 +43,7 @@ public bool Equals(NuGetReference other)
                    PackageVersion == other.PackageVersion;
         }
 
-        public override int GetHashCode()
-        {
-            return 557888800 + EqualityComparer<string>.Default.GetHashCode(PackageName) + EqualityComparer<string>.Default.GetHashCode(PackageVersion).GetHashCode();
-        }
+        public override int GetHashCode() => HashCode.Combine(PackageName, PackageVersion);
 
         public override string ToString() => $"{PackageName}{(string.IsNullOrWhiteSpace(PackageVersion) ? string.Empty : $" {PackageVersion}")}";
 
diff --git a/src/BenchmarkDotNet/Jobs/NugetReferenceList.cs b/src/BenchmarkDotNet/Jobs/NugetReferenceList.cs
diff --git a/src/BenchmarkDotNet/Reports/SummaryStyle.cs b/src/BenchmarkDotNet/Reports/SummaryStyle.cs
diff --git a/src/BenchmarkDotNet/Running/BenchmarkPartitioner.cs b/src/BenchmarkDotNet/Running/BenchmarkPartitioner.cs
diff --git a/src/BenchmarkDotNet/Toolchains/CsProj/CsProjGenerator.cs b/src/BenchmarkDotNet/Toolchains/CsProj/CsProjGenerator.cs
diff --git a/src/BenchmarkDotNet/Validators/ReturnValueValidator.cs b/src/BenchmarkDotNet/Validators/ReturnValueValidator.cs
diff --git a/src/BenchmarkDotNet/Validators/ValidationError.cs b/src/BenchmarkDotNet/Validators/ValidationError.cs

Original file line number	Diff line number	Diff line change
`@@ -64,15 +64,9 @@ public override bool Equals(object obj)`
`64`	`64`
`65`	`65`	`public override int GetHashCode()`
`66`	`66`	`{`
`67`		`- unchecked`
`68`		`- {`
`69`		`- int hashCode = AnalyserId.GetHashCode();`
`70`		`- hashCode = (hashCode * 397) ^ (int) Kind;`
`71`		`- hashCode = Mergeable`
`72`		`- ? (hashCode * 397) ^ Message.GetHashCode()`
`73`		`- : (hashCode * 397) ^ Report?.ToString().GetHashCode() ?? string.Empty.GetHashCode();`
`74`		`- return hashCode;`
`75`		`- }`
	`67`	`+ return Mergeable`
	`68`	`+ ? HashCode.Combine(AnalyserId, Kind, Message)`
	`69`	`+ : HashCode.Combine(AnalyserId, Kind, Report?.ToString());`
`76`	`70`	`}`
`77`	`71`	`}`
`78`	`72`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ protected override IEnumerable<Conclusion> AnalyseSummary(Summary summary)`
`21`	`21`	`var columnNames = string.Join(", ", hiddenColumns.Select(c => c.OriginalColumn.ColumnName));`
`22`	`22`
`23`	`23`	`var message = $"Hidden columns: {columnNames}";`
`24`		`- yield return Conclusion.CreateHint(Id, message);`
	`24`	`+ yield return CreateHint(message);`
`25`	`25`	`}`
`26`	`26`	`}`
`27`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -327,7 +327,7 @@ public bool Equals(Sharp x, Sharp y)`
`327`	`327`	`return x.FilePath == y.FilePath && x.LineNumber == y.LineNumber;`
`328`	`328`	`}`
`329`	`329`
`330`		`- public int GetHashCode(Sharp obj) => obj.FilePath.GetHashCode() ^ obj.LineNumber;`
	`330`	`+ public int GetHashCode(Sharp obj) => HashCode.Combine(obj.FilePath, obj.LineNumber);`
`331`	`331`	`}`
`332`	`332`	`}`
`333`		`-}`
	`333`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,6 @@ internal string GetRuntimeInfo()`
`70`	`70`	`return $"{RuntimeVersion}, {Architecture} {jitInfo}";`
`71`	`71`	`}`
`72`	`72`
`73`		`- [SuppressMessage("ReSharper", "UnusedMember.Global")] // TODO: should be used or removed`
`74`	`73`	`public static IEnumerable<ValidationError> Validate(Job job)`
`75`	`74`	`{`
`76`	`75`	`if (job.Environment.Jit == Jit.RyuJit && !RuntimeInformation.HasRyuJit())`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public static ClrRuntime CreateForLocalFullNetFrameworkBuild(string version)`
`40`	`40`
`41`	`41`	`public bool Equals(ClrRuntime other) => other != null && base.Equals(other) && Version == other.Version;`
`42`	`42`
`43`		`- public override int GetHashCode() => base.GetHashCode() ^ (Version?.GetHashCode() ?? 0);`
	`43`	`+ public override int GetHashCode() => HashCode.Combine(base.GetHashCode(), Version);`
`44`	`44`
`45`	`45`	`internal static ClrRuntime GetCurrentVersion()`
`46`	`46`	`{`
`@@ -69,4 +69,4 @@ internal static ClrRuntime GetCurrentVersion()`
`69`	`69`	`}`
`70`	`70`	`}`
`71`	`71`	`}`
`72`		`-}`
	`72`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,6 @@ public bool Equals(MonoAotLLVMRuntime other)`
`44`	`44`	`=> other != null && base.Equals(other) && other.AOTCompilerPath == AOTCompilerPath;`
`45`	`45`
`46`	`46`	`public override int GetHashCode()`
`47`		`- => base.GetHashCode() ^ AOTCompilerPath.GetHashCode();`
	`47`	`+ => HashCode.Combine(base.GetHashCode(), AOTCompilerPath);`
`48`	`48`	`}`
`49`		`-}`
	`49`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,6 @@ public bool Equals(MonoRuntime other)`
`41`	`41`	`=> base.Equals(other) && Name == other?.Name && CustomPath == other?.CustomPath && AotArgs == other?.AotArgs && MonoBclPath == other?.MonoBclPath;`
`42`	`42`
`43`	`43`	`public override int GetHashCode()`
`44`		`- => base.GetHashCode() ^ Name.GetHashCode() ^ (CustomPath?.GetHashCode() ?? 0) ^ (AotArgs?.GetHashCode() ?? 0) ^ (MonoBclPath?.GetHashCode() ?? 0);`
	`44`	`+ => HashCode.Combine(base.GetHashCode(), Name, CustomPath, AotArgs, MonoBclPath);`
`45`	`45`	`}`
`46`		`-}`
	`46`	`+}`