-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass arguments to runner in dotnet new templates #1658
Comments
Happy to, but in testing this out, I found it would otherwise force passing something like Still working on it, but any suggestions? |
Somewhat oddly, |
Seems the main culprit is:
If types were provided explicitly like in the following example that could be used in the template instead, perhaps, by default, the user shouldn't be prompted. Given the seeming intent of passing an explicit list of benchmark types, would you agree? BenchmarkSwitcher.FromTypes(new[] { typeof(Benchmarks) }).Run(args); |
To clarify, if that was the intent, I can go ahead and fix that problem in the |
You could add an overload to Otherwise you'll break anyone that relies on getting this prompt. |
Templates for
dotnet new
were added for #1028 but don't use any passed arguments for the runner. With the global tool deprecated, this world provide a convenient way of customizing frameworks, reports, etc. from a console.So instead of:
The templates could use:
The text was updated successfully, but these errors were encountered: