-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for runtimeconfig.template.json
#2428
Labels
Comments
Reopening for someone to add support for |
timcassell
changed the title
Can't set
Add support for Oct 27, 2023
RuntimeHostConfigurationOption
on generated projectruntimeconfig.template.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If I add RuntimeHostConfigurationOption to the benchmark project like this:
The built project will have this added to [appname].runtimeconfig.json:
This is important to be able to deal with this breaking change in .NET 8:
https://learn.microsoft.com/en-us/dotnet/core/compatibility/deployment/8.0/rid-asset-list#recommended-action
However, the generated project does not copy this setting over, so the resulting project will not get the correct value injected into its runtimeconfig.json.
An alternative way is to add a
runtimeconfig.template.json
file with the above json, but again, the generated project will not pick this up.Perhaps
BenchmarkDotNet/src/BenchmarkDotNet/Toolchains/CsProj/CsProjGenerator.cs
Line 26 in ece5ccf
RuntimeHostConfigurationOption
added, and also a way to make sureruntimeconfig.template.json
files are copied as well.The text was updated successfully, but these errors were encountered: