3.0's SilkTouch affected by a ClangSharp upstream bug whereby test code is in XML

[Perksey]

Example file: out.xml.txt

This needs to be fixed upstream in the ClangSharp repo and the version updated in our projects once a new update is released encompassing these changes.

The likely culprit is the OutputFactoryBuilder, but don't quote me on that.

Related dotnet/Silk.NET#557

[Perksey]

cc @tannergooding

[tannergooding]

So basically you want XML product code and C# tests?

[Perksey]

This particular issue is because we're getting C# test code added to the XML output file (only in single-file mode mind) even though the OutputMode is Xml and, to my knowledge, we're not enabling test output (which is presumably why the test implementations are empty)

dotnet/Silk.NET#557 is for discussing designing a way to get tests exposed in XML. But right now there should be no tests exposed in XML whatsoever, the bug is there are.

[Perksey]

@HurricanKai for visibility

[HurricanKai]

For future reference, this is what the issue looks like in the file:

[tannergooding]

This should be pretty straightforward to resolve in ClangSharp. We should really just have "single file mode" output separate files for "source" vs "tests".

If this is a priority, let me know and I can take a look at it sooner

[Perksey]

@tannergooding Should we transfer this issue into the ClangSharp repo? The 3.0 generator implementation is very changeable right now, such that it may not make sense to track here (because we may not hit this issue depending on what implementation is used in 3.0 proper)

[tannergooding]

Please feel free. Contributions also welcome to clean this up.

[Perksey]

@tannergooding I've given you triage access to this repo so hopefully you can use GitHub's built-in mechanism to transfer it & keep comments.

[tannergooding]

@Perksey, looks to have worked 🎉

[Perksey]

Awesome, thanks! 🎉