Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call base.OnConfiguring(optionsBuilder) in the getting started guide #3572

Closed
squiddie opened this issue Nov 18, 2021 · 2 comments · Fixed by #3652
Closed

Don't call base.OnConfiguring(optionsBuilder) in the getting started guide #3572

squiddie opened this issue Nov 18, 2021 · 2 comments · Fixed by #3652
Labels
area-getting-started closed-fixed community-contribution good first issue This issue should be relatively straightforward to fix.
Milestone
7.0.0

Comments

@squiddie
Copy link

[Enter feedback here]

The override of OnConfiguring calls the base function at the end. This can be cut as the base implementation does nothing.

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@ajcvickers ajcvickers added this to the Backlog milestone Nov 19, 2021
@ajcvickers ajcvickers added the good first issue This issue should be relatively straightforward to fix. label Nov 19, 2021
@Maniizzle
Copy link
Contributor

Hello @ajcvickers, Can i attend to this?

@roji
Copy link
Member

roji commented Dec 31, 2021

@Maniizzle sure, feel free to submit a PR for this.

@roji roji modified the milestones: Backlog, 7.0.0 Dec 31, 2021
@roji roji linked a pull request Dec 31, 2021 that will close this issue
Clean OnConfiguring Method #3652
Merged
@roji roji closed this as completed Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-getting-started closed-fixed community-contribution good first issue This issue should be relatively straightforward to fix.
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Clean OnConfiguring Method Maniizzle/EntityFramework.Docs
4 participants
@squiddie @ajcvickers @roji @Maniizzle