Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearly document safe/unsafe patterns for string interpolation #459

Closed
divega opened this issue Aug 21, 2017 · 1 comment
Closed

Clearly document safe/unsafe patterns for string interpolation #459

divega opened this issue Aug 21, 2017 · 1 comment
Assignees
@divega
Labels
closed-duplicate punted-for-2.2

Comments

@divega
Copy link
Contributor

divega commented Aug 21, 2017

See
https://twitter.com/nick_craver/status/899629701836283904.

It is still possible to misuse string interpolation if the string is built outside the call because the compiler always favors an implicit conversion to string.

We should show how to do this correctly.

Also brainstorm other mitigations.
@ajcvickers ajcvickers added this to the 2.1.0 milestone Sep 18, 2017
@divega divega modified the milestones: 2.1.0, 2.2.0 Jul 10, 2018
@divega divega self-assigned this Jul 31, 2018
@divega divega modified the milestones: 2.2.0, 3.0.0 Feb 21, 2019
@ajcvickers
Copy link
Contributor

Superceeded by #410

@ajcvickers ajcvickers removed this from the 3.0.0 milestone Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@divega divega

Labels
closed-duplicate punted-for-2.2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anpete @divega @ajcvickers