Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version schema only allows lower case pre-release versions #1110

Open
valepakh opened this issue Oct 24, 2024 · 2 comments
Open

Version schema only allows lower case pre-release versions #1110

valepakh opened this issue Oct 24, 2024 · 2 comments

Comments

@valepakh
Copy link

Current version pattern in the version.schema.json allows only lower case pre-release version [\da-z\-] while the semver specification allows any case:

Identifiers MUST comprise only ASCII alphanumerics and hyphens [0-9A-Za-z-]

@KalleOlaviNiemitalo
Copy link

.NET SDK has known bugs for upper-case versions in tools: dotnet/sdk#24419, dotnet/sdk#39105.
The current pattern at least reduces the risk of users hitting those bugs.

@AArnott
Copy link
Collaborator

AArnott commented Nov 7, 2024

I'd take a PR that fixes this. But as the current bug protects you from .NET SDK bugs, I agree with @KalleOlaviNiemitalo and am in no personal rush to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants