Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document recommended workflow for updating version.json #127

Open
AArnott opened this issue May 30, 2017 · 4 comments
Open

Document recommended workflow for updating version.json #127

AArnott opened this issue May 30, 2017 · 4 comments
Assignees

Comments

@AArnott
Copy link
Collaborator

AArnott commented May 30, 2017

As @onovotny suggested, there should be documentation guiding the how, when, and where of updating version.json files around releases, servicing branches, etc.

@AArnott AArnott self-assigned this May 30, 2017
@josesimoes
Copy link

To make this more efficient it would be even better if the version could bump itself.
Kind of the way gitversion works: have a config for the version and option to bump major/minor/revision on a tag, or on release, or from a build parameter/variable.

I mean having to manually edit the version.json on each "release" and after that on the next iteration on "develop" is a bit cumbersome and not very efficient considering that you have to commit, push, pull, etc.

@AArnott
Copy link
Collaborator Author

AArnott commented Jan 17, 2019

@josesimoes NB.GV intentionally requires a commit to be authored to change the version. Merely branching or tagging is not an input into this process because such things can come and go in git, making it difficult to come back later and ascertain which commit built a particular version, or what version a commit was built with. This is perhaps the most distinguishing characteristic between GitVersion and NB.GV that to me justifies the two competing libraries -- people have their preferences on this and can choose which one to use, but where GitVersion prioritizes auto-versioning, NB.GV prioritizes repeatable, deterministic builds and servicing.

That said, #287 tracks a suggestion that will likely be implemented very soon that streamlines the process of updating version.json for releases that might interest you.

@josesimoes
Copy link

I can fully understand what you've just describe and that makes sense. Just peeked #287 and I believe something like what's being discussed over there would be a real helper on handling this more efficiently.

In the mean time (as this issue is all about) a more detailed description on the intended/expected workflow around version.json would be very helpful.

@LoremFooBar
Copy link
Contributor

I'm sorry to bump this old issue... As a new user, I find the documentation to be somewhat overwhelming. It will be very helpful if the documentation guides new users on the recommended usage in terms of installation, branching, updating version.json, CI flow, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants