First round of code review

Correct casing and escaping of query.
Factor new tests into their own classes, allow them to run against Azure SQL.

Author: edwardneal

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs

@@ -471,13 +471,13 @@ private string CreateInitialQuery()
 SELECT @@TRANCOUNT;
 
 DECLARE @Column_Names NVARCHAR(MAX) = NULL;
-IF EXISTS (SELECT TOP 1 * FROM sys.all_columns where object_id = object_id('sys.all_columns') AND [name] = 'graph_type')
+IF EXISTS (SELECT TOP 1 * FROM sys.all_columns WHERE [object_id] = OBJECT_ID('sys.all_columns') AND [name] = 'graph_type')
 BEGIN
-    SELECT @Column_Names = COALESCE(@Column_Names + ', ', '') + QUOTENAME(name) FROM {CatalogName}.sys.all_columns WHERE OBJECT_ID = OBJECT_ID('{escapedObjectName}') AND COALESCE(graph_type, 0) NOT IN (1, 3, 4, 6, 7) ORDER BY column_id ASC;
+    SELECT @Column_Names = COALESCE(@Column_Names + ', ', '') + QUOTENAME([name]) FROM {CatalogName}.[sys].[all_columns] WHERE [object_id] = OBJECT_ID('{escapedObjectName}') AND COALESCE([graph_type], 0) NOT IN (1, 3, 4, 6, 7) ORDER BY [column_id] ASC;
 END
 ELSE
 BEGIN
-    SELECT @Column_Names = COALESCE(@Column_Names + ', ', '') + QUOTENAME(name) FROM {CatalogName}.sys.all_columns WHERE OBJECT_ID = OBJECT_ID('{escapedObjectName}') ORDER BY column_id ASC;
+    SELECT @Column_Names = COALESCE(@Column_Names + ', ', '') + QUOTENAME([name]) FROM {CatalogName}.[sys].[all_columns] WHERE [object_id] = OBJECT_ID('{escapedObjectName}') ORDER BY [column_id] ASC;
 END
 
 SELECT @Column_Names = COALESCE(@Column_Names, '*');

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlBulkCopyTest/HiddenTargetColumn.cs

@@ -6,21 +6,25 @@
 using System.Data.Common;
 using Xunit;
 
-namespace Microsoft.Data.SqlClient.ManualTesting.Tests
+namespace Microsoft.Data.SqlClient.ManualTesting.Tests.SqlBulkCopyTests
 {
     public class HiddenTargetColumn
     {
-        public static void Test(string srcConstr, string dstConstr, string dstTable)
+        [ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
+        public void WriteToServer_CopyToHiddenTargetColumn_ThrowsSqlException()
         {
-            using (SqlConnection dstConn = new SqlConnection(dstConstr))
+            string connectionString = DataTestUtility.TCPConnectionString;
+            string destinationTable = DataTestUtility.GetUniqueNameForSqlServer("HiddenTargetColumn");
+            string destinationHistoryTable = DataTestUtility.GetUniqueNameForSqlServer("HiddenTargetColumn_History");
+
+            using (SqlConnection dstConn = new SqlConnection(connectionString))
             using (SqlCommand dstCmd = dstConn.CreateCommand())
             {
                 dstConn.Open();
 
                 try
                 {
-                    Helpers.TryExecute(dstCmd, $"""
-create table dbo.{dstTable}
+                    DataTestUtility.CreateTable(dstConn, destinationTable, $"""
 (
     Column1 int primary key not null,
     Column2 nvarchar(10) not null,
@@ -29,18 +33,18 @@ Column2 nvarchar(10) not null,
     ValidTo datetime2 generated always as row end hidden not null,
     period for system_time (ValidFrom, ValidTo)
 )
-with (system_versioning = on(history_table = dbo.{dstTable}_History));
+with (system_versioning = on(history_table = dbo.{destinationHistoryTable}));
 """);
 
-                    using (SqlConnection srcConn = new SqlConnection(srcConstr))
+                    using (SqlConnection srcConn = new SqlConnection(connectionString))
                     using (SqlCommand srcCmd = new SqlCommand("select top 5 EmployeeID, FirstName, LastName, HireDate, sysdatetime() as CurrentDate from employees", srcConn))
                     {
                         srcConn.Open();
 
                         using (DbDataReader reader = srcCmd.ExecuteReader())
                         using (SqlBulkCopy bulkcopy = new SqlBulkCopy(dstConn))
                         {
-                            bulkcopy.DestinationTableName = dstTable;
+                            bulkcopy.DestinationTableName = destinationTable;
                             SqlBulkCopyColumnMappingCollection ColumnMappings = bulkcopy.ColumnMappings;
 
                             ColumnMappings.Add("EmployeeID", "Column1");
@@ -52,18 +56,18 @@ Column2 nvarchar(10) not null,
                             SqlException sqlEx = Assert.Throws<SqlException>(() => bulkcopy.WriteToServer(reader));
 
                             Assert.Equal(13536, sqlEx.Number);
-                            Assert.StartsWith($"Cannot insert an explicit value into a GENERATED ALWAYS column in table '{dstConn.Database}.dbo.{dstTable}'.", sqlEx.Message);
+                            Assert.StartsWith($"Cannot insert an explicit value into a GENERATED ALWAYS column in table '{dstConn.Database}.dbo.{destinationTable.Replace("[", "").Replace("]", "")}'.", sqlEx.Message);
                         }
                     }
                 }
                 finally
                 {
-                    Helpers.TryExecute(dstCmd, $"""
-alter table {dstTable} set (system_versioning = off);
-alter table {dstTable} drop period for system_time;
-drop table {dstTable}
-drop table {dstTable}_History
+                    DataTestUtility.RunNonQuery(connectionString, $"""
+alter table {destinationTable} set (system_versioning = off);
+alter table {destinationTable} drop period for system_time;
 """);
+                    DataTestUtility.DropTable(dstConn, destinationTable);
+                    DataTestUtility.DropTable(dstConn, destinationHistoryTable);
                 }
             }
         }

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlBulkCopyTest/SqlBulkCopyTest.cs

@@ -109,17 +109,6 @@ public void MissingTargetColumnsTest()
         {
             MissingTargetColumns.Test(_connStr, _connStr, AddGuid("SqlBulkCopyTest_MissingTargetColumns"));
         }
-        [ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
-        public void HiddenTargetColumnTest()
-        {
-            HiddenTargetColumn.Test(_connStr, _connStr, AddGuid("SqlBulkCopyTest_HiddenTargetColumn"));
-        }
-
-        [ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
-        public void SqlGraphTablesTest()
-        {
-            SqlGraphTables.Test(_connStr, AddGuid("SqlBulkCopyTest_SqlGraphTables_Node"));
-        }
 
         [ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureServer))]
         public void Bug85007Test()

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlBulkCopyTest/SqlGraphTables.cs

@@ -7,13 +7,17 @@
 using System.Data.Common;
 using Xunit;
 
-namespace Microsoft.Data.SqlClient.ManualTesting.Tests
+namespace Microsoft.Data.SqlClient.ManualTesting.Tests.SqlBulkCopyTests
 {
     public class SqlGraphTables
     {
-        public static void Test(string dstConnectionString, string dstNodeTable)
+        [ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
+        public void WriteToServer_CopyToSqlGraphNodeTable_Succeeds()
         {
-            using SqlConnection dstConn = new SqlConnection(dstConnectionString);
+            string connectionString = DataTestUtility.TCPConnectionString;
+            string destinationTable = DataTestUtility.GetUniqueNameForSqlServer("SqlGraphNodeTable");
+
+            using SqlConnection dstConn = new SqlConnection(connectionString);
             using DataTable nodes = new DataTable()
             {
                 Columns = { new DataColumn("Name", typeof(string)) }
@@ -28,17 +32,17 @@ public static void Test(string dstConnectionString, string dstNodeTable)
 
             try
             {
-                DataTestUtility.CreateTable(dstConn, dstNodeTable, "(Id INT PRIMARY KEY IDENTITY(1,1), [Name] VARCHAR(100)) AS NODE");
+                DataTestUtility.CreateTable(dstConn, destinationTable, "(Id INT PRIMARY KEY IDENTITY(1,1), [Name] VARCHAR(100)) AS NODE");
 
                 using SqlBulkCopy nodeCopy = new SqlBulkCopy(dstConn);
 
-                nodeCopy.DestinationTableName = dstNodeTable;
+                nodeCopy.DestinationTableName = destinationTable;
                 nodeCopy.ColumnMappings.Add("Name", "Name");
                 nodeCopy.WriteToServer(nodes);
             }
             finally
             {
-                DataTestUtility.DropTable(dstConn, dstNodeTable);
+                DataTestUtility.DropTable(dstConn, destinationTable);
             }
         }
     }