Skip to content

Commit

Permalink
review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
Kaur-Parminder committed Apr 20, 2023
1 parent a659462 commit c7ee37d
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 18 deletions.
10 changes: 2 additions & 8 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

## [Preview Release 5.2.0-preview1.23109.1] - 2023-04-19
## [Preview Release 5.2.0-preview1.23109.1] - 2023-04-20

This update brings the below changes over the previous release:

Expand Down Expand Up @@ -33,13 +33,7 @@ This update brings the below changes over the previous release:
- Add and use TryReadChars method. [#1544] (https://github.com/dotnet/SqlClient/pull/1544)
- Removed reference to Microsoft.Win32.Registry since it's shipped starting with .NET 6.0. [#1974](https://github.com/dotnet/SqlClient/pull/1974)
- Added Microsoft.SqlServer.Types to verify support for SqlHierarchyId and Spatial for .NET Core. [#1848] (https://github.com/dotnet/SqlClient/pull/1848)

### Code health improvements

- Replaced calls to Method.GetCurrentMethod().Name with nameof(). [#1943] (https://github.com/dotnet/SqlClient/pull/1943)
- Removed LINQ operations. [#1949] (https://github.com/dotnet/SqlClient/pull/1949)
- Added allocation free path for close notifications. [#1198] (https://github.com/dotnet/SqlClient/pull/1198)
- Stopped creation of parameter prefixed names. [#1829](https://github.com/dotnet/SqlClient/pull/1829)
- Code health improvements:[#1943] (https://github.com/dotnet/SqlClient/pull/1943)[#1949] (https://github.com/dotnet/SqlClient/pull/1949)[#1198] (https://github.com/dotnet/SqlClient/pull/1198)[#1829](https://github.com/dotnet/SqlClient/pull/1829)

## [Stable release 5.1.1] - 2023-03-28

Expand Down
10 changes: 2 additions & 8 deletions release-notes/5.2/5.2.0-preview1.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Release Notes

## [Preview Release 5.2.0-preview1.23109.1] - 2023-04-19
## [Preview Release 5.2.0-preview1.23109.1] - 2023-04-20

This update brings the below changes over the previous release:

Expand Down Expand Up @@ -29,13 +29,7 @@ This update brings the below changes over the previous release:
- Add and use TryReadChars method. [#1544] (https://github.com/dotnet/SqlClient/pull/1544)
- Removed reference to Microsoft.Win32.Registry since it's shipped starting with .NET 6.0. [#1974](https://github.com/dotnet/SqlClient/pull/1974)
- Added Microsoft.SqlServer.Types to verify support for SqlHierarchyId and Spatial for .NET Core. [#1848] (https://github.com/dotnet/SqlClient/pull/1848)

### Code health improvements

- Replaced calls to Method.GetCurrentMethod().Name with nameof(). [#1943] (https://github.com/dotnet/SqlClient/pull/1943)
- Removed LINQ operations. [#1949] (https://github.com/dotnet/SqlClient/pull/1949)
- Added allocation free path for close notifications. [#1198] (https://github.com/dotnet/SqlClient/pull/1198)
- Stopped creation of parameter prefixed names. [#1829](https://github.com/dotnet/SqlClient/pull/1829)
- Code health improvements:[#1943] (https://github.com/dotnet/SqlClient/pull/1943)[#1949] (https://github.com/dotnet/SqlClient/pull/1949)[#1198] (https://github.com/dotnet/SqlClient/pull/1198)[#1829](https://github.com/dotnet/SqlClient/pull/1829)

## Target Platform Support

Expand Down
2 changes: 1 addition & 1 deletion release-notes/5.2/5.2.0.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
| Release Date | Version | Notes |
| :-- | :-- | :--: |
| 2023/04/19 | 5.2.0-preview1.23109.1 | [release notes](5.2.0-preview1.md) |
| 2023/04/20 | 5.2.0-preview1.23109.1 | [release notes](5.2.0-preview1.md) |
2 changes: 1 addition & 1 deletion release-notes/5.2/README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
| Release Date | Version | Notes |
| :-- | :-- | :--: |
| 2023/04/19 | 5.2.0-preview1.23109.1 | [release notes](5.2.0-preview1.md) |
| 2023/04/20 | 5.2.0-preview1.23109.1 | [release notes](5.2.0-preview1.md) |

0 comments on commit c7ee37d

Please sign in to comment.