Remove optional default parameters

edwardneal · edwardneal · commit d1d3669d0568 · 2025-04-10T00:57:48.000+01:00
diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs
@@ -2368,7 +2368,7 @@ private static void ChangePassword(string connectionString, SqlConnectionString
             SqlInternalConnectionTds con = null;
             try
             {
-                con = new SqlInternalConnectionTds(null, connectionOptions, credential, null, newPassword, newSecurePassword, false, null, null, null, null);
+                con = new SqlInternalConnectionTds(null, connectionOptions, credential, null, newPassword, newSecurePassword, false);
             }
             finally
             {
@@ -2491,7 +2491,7 @@ public IDictionary<string, object> RetrieveInternalInfo()
         private Assembly ResolveTypeAssembly(AssemblyName asmRef, bool throwOnError)
         {
             Debug.Assert(TypeSystemAssemblyVersion != null, "TypeSystemAssembly should be set !");
-            if (string.Compare(asmRef.Name, "Microsoft.SqlServer.Types", StringComparison.OrdinalIgnoreCase) == 0)
+            if (string.Equals(asmRef.Name, "Microsoft.SqlServer.Types", StringComparison.OrdinalIgnoreCase))
             {
                 if (asmRef.Version != TypeSystemAssemblyVersion && SqlClientEventSource.Log.IsTraceEnabled())
                 {

Original file line number	Diff line number	Diff line change
`@@ -2368,7 +2368,7 @@ private static void ChangePassword(string connectionString, SqlConnectionString`
`2368`	`2368`	`SqlInternalConnectionTds con = null;`
`2369`	`2369`	`try`
`2370`	`2370`	`{`
`2371`		`- con = new SqlInternalConnectionTds(null, connectionOptions, credential, null, newPassword, newSecurePassword, false, null, null, null, null);`
	`2371`	`+ con = new SqlInternalConnectionTds(null, connectionOptions, credential, null, newPassword, newSecurePassword, false);`
`2372`	`2372`	`}`
`2373`	`2373`	`finally`
`2374`	`2374`	`{`
`@@ -2491,7 +2491,7 @@ public IDictionary<string, object> RetrieveInternalInfo()`
`2491`	`2491`	`private Assembly ResolveTypeAssembly(AssemblyName asmRef, bool throwOnError)`
`2492`	`2492`	`{`
`2493`	`2493`	`Debug.Assert(TypeSystemAssemblyVersion != null, "TypeSystemAssembly should be set !");`
`2494`		`- if (string.Compare(asmRef.Name, "Microsoft.SqlServer.Types", StringComparison.OrdinalIgnoreCase) == 0)`
	`2494`	`+ if (string.Equals(asmRef.Name, "Microsoft.SqlServer.Types", StringComparison.OrdinalIgnoreCase))`
`2495`	`2495`	`{`
`2496`	`2496`	`if (asmRef.Version != TypeSystemAssemblyVersion && SqlClientEventSource.Log.IsTraceEnabled())`
`2497`	`2497`	`{`