-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change | Revert excluding unsupported protocols #1824
Conversation
Codecov ReportBase: 71.41% // Head: 71.31% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1824 +/- ##
==========================================
- Coverage 71.41% 71.31% -0.10%
==========================================
Files 290 290
Lines 61280 61271 -9
==========================================
- Hits 43761 43697 -64
- Misses 17519 17574 +55
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. just verified it with my changes and it works! Thanks!
/AzurePipelines Run |
Azure Pipelines successfully started running 1 pipeline(s). |
Regarding issue #1151 and related PR #1168, the proposed changes are not required anymore since Windows 10 and/or SQL Server 2019 have fixed the issue while Microsoft.Data.SqlClient has been adding support for TLS 1.3.