Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Azure.Identity dependency to version 1.8.0 #1919

Closed
scottaddie opened this issue Feb 7, 2023 · 5 comments
Closed

Upgrade Azure.Identity dependency to version 1.8.0 #1919

scottaddie opened this issue Feb 7, 2023 · 5 comments
Assignees
Labels
💡 Enhancement Issues that are feature requests for the drivers we maintain.

Comments

@scottaddie
Copy link
Member

In v1.8.0 of the Azure Identity library for .NET (Azure.Identity), token caching was added for the ManagedIdentityCredential type. Token lifetime and refreshing is handled automatically. See https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/identity/Azure.Identity/CHANGELOG.md#180-beta1-2022-10-13. Under the hood, MSAL's in-memory cache is used. This dependency upgrade will help mitigate Azure AD throttling issues that occur from calling it too frequently.

For Java customers, this issue has already been addressed as of the latest stable JDBC driver release. See microsoft/mssql-jdbc#1930.

/cc: @David-Engel

@scottaddie scottaddie changed the title Upgrade Azure.Identity dependency to 1.8.0 Upgrade Azure.Identity dependency to version 1.8.0 Feb 7, 2023
@ErikEJ
Copy link
Contributor

ErikEJ commented Feb 7, 2023

@scottaddie So an explicit update to 1.8.0 will also add automagic caching?

@lcheunglci lcheunglci added the 🆕 Triage Needed For new issues, not triaged yet. label Feb 7, 2023
@lcheunglci
Copy link
Contributor

lcheunglci commented Feb 7, 2023

Thanks @scottaddie for making the suggestion. I do believe by upgrading this dependency it would also resolve #1900 and we can consider upgrading it in our next release and I'll bring it up to the team and get back to you soon.

@scottaddie
Copy link
Member Author

@scottaddie So an explicit update to 1.8.0 will also add automagic caching?

That's correct, @ErikEJ. Caching is enabled by default. No app code changes are required to use it.

@lcheunglci lcheunglci added this to the 5.2.0 milestone Feb 7, 2023
@lcheunglci lcheunglci added 💡 Enhancement Issues that are feature requests for the drivers we maintain. and removed 🆕 Triage Needed For new issues, not triaged yet. labels Feb 7, 2023
@lcheunglci lcheunglci self-assigned this Feb 7, 2023
@lcheunglci
Copy link
Contributor

Thanks @scottaddie for the suggestion and Azure Identity 1.8.0 would be included in the 5.2 release.

@scottaddie
Copy link
Member Author

@lcheunglci The following issue should also be resolved with this dependency upgrade: #1495

@lcheunglci lcheunglci removed this from the 5.2.0-preview1 milestone Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Enhancement Issues that are feature requests for the drivers we maintain.
Projects
None yet
Development

No branches or pull requests

3 participants