Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect copied log messages #972

Closed
nickljones opened this issue Mar 8, 2021 · 2 comments
Closed

Incorrect copied log messages #972

nickljones opened this issue Mar 8, 2021 · 2 comments

Comments

@nickljones
Copy link

Describe the bug

long scopeID = SqlClientEventSource.Log.TrySNIScopeEnterEvent("<sc.SNI.SNIMarsHandle.SendAsync |SNI|INFO|SCOPE>");

is logged in the following methods:

  • SNIMarsHandle.SendAsync
  • SNIMarsHandle.ReceiveAsync
  • SNITcpHandle.SendAsync

Expected behavior

Each method should have a distinct message corresponding to the method name in which it is logged

Further technical details

Microsoft.Data.SqlClient version: 2.1.2

@nickljones nickljones changed the title Incorrect copies log messages Incorrect copied log messages Mar 8, 2021
@cheenamalhotra
Copy link
Member

Hi @nickljones

We're improving this design in future versions.
It's a huge effort so it's being done in parts. (ref: PR #897)

@JRahnama
Copy link
Contributor

JRahnama commented Sep 2, 2022

Closing this as PR #897 was merged. Feel free to open a new issue if the concern is not addressed yet.

@JRahnama JRahnama closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants