Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback to the plan for Torch integration to ML.NET #328

Closed
GeorgeS2019 opened this issue Aug 17, 2021 · 2 comments
Closed

Feedback to the plan for Torch integration to ML.NET #328

GeorgeS2019 opened this issue Aug 17, 2021 · 2 comments

Comments

@GeorgeS2019
Copy link

GeorgeS2019 commented Aug 17, 2021

TorchSharp integration to ML.NETis currently being planned (supervised by @ericstj ) as recently shared/discussed by @NiklasGustafsson

I suggest TorchSharp users provide feedback to the integration process here.

As part of the integration, the question how to consume exported Torch model by ML.NET has been planned.

I also would like to raise some issues raised before related to the above.

  • Will there be an improvement in how TorchSharp consume Torch model created in python. Currently we need an additional python script to create a TorchSharp compatible model in python. Is there a plan soon that this additional step will be removed, perhaps as part of the ML.NET integration planning process?
  • There are challenges dealing with ONNX, especially when dealing with NLP use cases (e.g. ref 1, ref 2). Is there a plan to consider incorporating ONNX save and load features in TorchSharp? By having Onnx save/load in TorchSharp, this provides an alternative path to the existing option to import ONNX to ML.NET
@ericstj
Copy link
Member

ericstj commented Aug 17, 2021

cc @michaelgsharp @briacht
At the moment we're still trying to understand what this work would look like. Thanks for raising concerns and we'll make sure to stay engaged in the discussion.

@GeorgeS2019
Copy link
Author

GeorgeS2019 commented Aug 30, 2021

FYI: latest plan for Deep learning and TorchSharp integration to ML.NET!!!

@dotnet dotnet locked and limited conversation to collaborators Aug 31, 2021
@dsyme dsyme closed this as completed Aug 31, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants