Added ToJavaEscapedPath

Author: dellis1972

src/Xamarin.Android.Build.Tasks/Tasks/JavaCompileToolTask.cs

@@ -78,7 +78,7 @@ private void GenerateResponseFile ()
 				// Include any user .java files
 				if (JavaSourceFiles != null)
 					foreach (var file in JavaSourceFiles.Where (p => Path.GetExtension (p.ItemSpec) == ".java"))
-						sw.WriteLine (string.Format ("\"{0}\"", file.ItemSpec.Replace (@"\", @"\\")));					
+						sw.WriteLine (string.Format ("\"{0}\"", file.ItemSpec.ToJavaEscapedPath ()));					
 
 				foreach (var file in Directory.GetFiles (StubSourceDirectory, "*.java", SearchOption.AllDirectories)) {
 					// This makes sense.  BAD sense.  but sense.
@@ -95,7 +95,7 @@ private void GenerateResponseFile ()
 					//    Since '\' is an escape character, we need to escape it.
 					// [0] http://download.oracle.com/javase/1.4.2/docs/api/java/io/StreamTokenizer.html#quoteChar(int)
 					sw.WriteLine (string.Format ("\"{0}\"",
-								file.Replace (@"\", @"\\").Normalize (NormalizationForm.FormC)));
+								file.ToJavaEscapedPath ()));
 				}
 			}
 		}

src/Xamarin.Android.Build.Tasks/Tasks/Javac.cs

@@ -67,9 +67,9 @@ protected override string GenerateCommandLineCommands ()
 
 		protected override void WriteOptionsToResponseFile (StreamWriter sw)
 		{
-			WriteLineToStreamWriterAndLog (sw, $"-d {Files.GetShortPath(ClassesOutputDirectory).Replace(@"\", @"\\").Normalize(NormalizationForm.FormC)}");
-			WriteLineToStreamWriterAndLog (sw, "-bootclasspath {0}", Files.GetShortPath(JavaPlatformJarPath).Replace(@"\", @"\\").Normalize(NormalizationForm.FormC));
-			WriteLineToStreamWriterAndLog (sw, "-classpath \"{0}\"", Jars == null || !Jars.Any () ? null : string.Join (Path.PathSeparator.ToString (), Jars.Select (i => i.ItemSpec.Replace(@"\", @"\\").Normalize(NormalizationForm.FormC))));
+			WriteLineToStreamWriterAndLog (sw, $"-d \"{Files.GetShortPath(ClassesOutputDirectory).ToJavaEscapedPath ()}\"");
+			WriteLineToStreamWriterAndLog (sw, "-bootclasspath \"{0}\"", Files.GetShortPath(JavaPlatformJarPath).ToJavaEscapedPath ());
+			WriteLineToStreamWriterAndLog (sw, "-classpath \"{0}\"", Jars == null || !Jars.Any () ? null : string.Join (Path.PathSeparator.ToString (), Jars.Select (i => i.ItemSpec.ToJavaEscapedPath ())));
 			WriteLineToStreamWriterAndLog (sw, $"-encoding UTF8");
 		}
 

src/Xamarin.Android.Build.Tasks/Utilities/MonoAndroidHelper.cs

@@ -19,7 +19,7 @@
 
 namespace Xamarin.Android.Tasks
 {
-	public class MonoAndroidHelper
+	public static class MonoAndroidHelper
 	{
 		static Lazy<string> uname = new Lazy<string> (GetOSBinDirName, System.Threading.LazyThreadSafetyMode.PublicationOnly);
 
@@ -600,5 +600,10 @@ public static Dictionary<string, string> LoadResourceCaseMap (string resourceCas
 			}
 			return result;
 		}
+
+		public static string ToJavaEscapedPath (this string value)
+		{
+			return value.Replace (@"\", @"\\").Normalize (NormalizationForm.FormC);
+		}
 	}
 }