Skip to content

Commit 45d9db5

Browse files
committed
Move test to MSBuildDeviceIntegration
1 parent 9ec2246 commit 45d9db5

File tree

2 files changed

+43
-42
lines changed

2 files changed

+43
-42
lines changed

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BindingBuildTest.cs

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -643,48 +643,6 @@ public void NothingToBind (string classParser)
643643
}
644644
}
645645

646-
[Test]
647-
public void AppWithAndroidJavaSource ()
648-
{
649-
var path = Path.Combine ("temp", TestName);
650-
var proj = new XamarinAndroidApplicationProject {
651-
OtherBuildItems = {
652-
new AndroidItem.AndroidJavaSource ("TestJavaClass.java") {
653-
Encoding = Encoding.ASCII,
654-
TextContent = () => @"package com.test.java;
655-
656-
public class TestJavaClass {
657-
658-
public String test(){
659-
660-
return ""Java is called"";
661-
}
662-
}",
663-
Metadata = {
664-
{ "Bind", "True" },
665-
},
666-
},
667-
}
668-
};
669-
using (var b = CreateApkBuilder ()) {
670-
b.ThrowOnBuildFailure = false;
671-
Assert.IsTrue (b.Build (proj), "Build should have succeeded.");
672-
b.AssertHasNoWarnings ();
673-
var generatedCode = Path.Combine (Root, b.ProjectDirectory, proj.IntermediateOutputPath,
674-
"generated", "src", "Com.Test.Java.TestJavaClass.cs");
675-
FileAssert.Exists (generatedCode, $"'{generatedCode}' should have been generated.");
676-
Assert.IsTrue (b.DesignTimeBuild (proj, target: "UpdateGeneratedFiles"), "DTB should have succeeded.");
677-
Assert.IsTrue (b.Output.IsTargetSkipped ("_ClearGeneratedManagedBindings", defaultIfNotUsed: true), $"`_ClearGeneratedManagedBindings` should be skipped on DTB build!");
678-
FileAssert.Exists (generatedCode, $"'{generatedCode}' should have not be deleted on DTB build.");
679-
Assert.IsTrue (b.Build (proj, doNotCleanupOnUpdate: true, saveProject: false), "Second build should have succeeded.");
680-
FileAssert.Exists (generatedCode, $"'{generatedCode}' should have not be deleted on second build.");
681-
Assert.IsTrue (b.Output.IsTargetSkipped ("_ClearGeneratedManagedBindings"), $"`_ClearGeneratedManagedBindings` should be skipped on second build!");
682-
Assert.IsTrue (b.Install (proj, doNotCleanupOnUpdate: true, saveProject: false), "Install build should have succeeded.");
683-
FileAssert.Exists (generatedCode, $"'{generatedCode}' should have not be deleted on Install build.");
684-
Assert.IsTrue (b.Output.IsTargetSkipped ("_ClearGeneratedManagedBindings"), $"`_ClearGeneratedManagedBindings` should be skipped on Install build!");
685-
}
686-
}
687-
688646
[Test]
689647
public void BindingWithAndroidJavaSource ()
690648
{

tests/MSBuildDeviceIntegration/Tests/InstallTests.cs

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -610,5 +610,48 @@ public void AdbTargetChangesAppBundle ()
610610
var after = File.GetLastWriteTimeUtc (apkset);
611611
Assert.AreNotEqual (before, after, $"{apkset} should change!");
612612
}
613+
614+
[Test]
615+
public void AppWithAndroidJavaSource ()
616+
{
617+
var path = Path.Combine ("temp", TestName);
618+
var proj = new XamarinAndroidApplicationProject {
619+
OtherBuildItems = {
620+
new AndroidItem.AndroidJavaSource ("TestJavaClass.java") {
621+
Encoding = Encoding.ASCII,
622+
TextContent = () => @"package com.test.java;
623+
624+
public class TestJavaClass {
625+
626+
public String test(){
627+
628+
return ""Java is called"";
629+
}
630+
}",
631+
Metadata = {
632+
{ "Bind", "True" },
633+
},
634+
},
635+
}
636+
};
637+
using (var b = CreateApkBuilder ()) {
638+
b.ThrowOnBuildFailure = false;
639+
Assert.IsTrue (b.Build (proj), "Build should have succeeded.");
640+
b.AssertHasNoWarnings ();
641+
var generatedCode = Path.Combine (Root, b.ProjectDirectory, proj.IntermediateOutputPath,
642+
"generated", "src", "Com.Test.Java.TestJavaClass.cs");
643+
FileAssert.Exists (generatedCode, $"'{generatedCode}' should have been generated.");
644+
Assert.IsTrue (b.DesignTimeBuild (proj, target: "UpdateGeneratedFiles"), "DTB should have succeeded.");
645+
Assert.IsTrue (b.Output.IsTargetSkipped ("_ClearGeneratedManagedBindings", defaultIfNotUsed: true), $"`_ClearGeneratedManagedBindings` should be skipped on DTB build!");
646+
FileAssert.Exists (generatedCode, $"'{generatedCode}' should have not be deleted on DTB build.");
647+
Assert.IsTrue (b.Build (proj, doNotCleanupOnUpdate: true, saveProject: false), "Second build should have succeeded.");
648+
FileAssert.Exists (generatedCode, $"'{generatedCode}' should have not be deleted on second build.");
649+
Assert.IsTrue (b.Output.IsTargetSkipped ("_ClearGeneratedManagedBindings"), $"`_ClearGeneratedManagedBindings` should be skipped on second build!");
650+
// Call Install directly so Build does not get called automatically
651+
Assert.IsTrue (b.RunTarget (proj, "Install", doNotCleanupOnUpdate: true, saveProject: false), "Install build should have succeeded.");
652+
FileAssert.Exists (generatedCode, $"'{generatedCode}' should have not be deleted on Install build.");
653+
Assert.IsTrue (b.Output.IsTargetSkipped ("_ClearGeneratedManagedBindings", defaultIfNotUsed: true), $"`_ClearGeneratedManagedBindings` should be skipped on Install build!");
654+
}
655+
}
613656
}
614657
}

0 commit comments

Comments
 (0)