Commit c2d3681
[Xamarin.Android.Build.Tasks] _CopyIntermediateAssemblies uses CopyIfChanged (#2128)
Context: #2088
970da9e was a good step towards "correctness" in building
incrementally in the following scenario:
- File | New Xamarin.Forms project | NetStandard library
- Build
- Change XAML
- Build
In this scenario, there is now a new target rising to the surface we
can improve:
276 ms _CopyIntermediateAssemblies 1 calls
Looking at the target, it seems we could use the `CopyIfChanged` task
here more effectively. This task will automaticaly set the timestamps
of files that have been copied, and so we don't need any subsequent
`<ItemGroup />` or `<Touch />` elements. It was also touching *all*
files instead of just the ones that were changed.
After this change:
33 ms _CopyIntermediateAssemblies 1 calls
The overall build went from 7.058s to 6.652s, so there must be some
other targets that benefit from the timestamps not changing on *all*
of these files.1 parent 2598be5 commit c2d3681
File tree
1 file changed
+3
-8
lines changed- src/Xamarin.Android.Build.Tasks
1 file changed
+3
-8
lines changedLines changed: 3 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1943 | 1943 | | |
1944 | 1944 | | |
1945 | 1945 | | |
1946 | | - | |
| 1946 | + | |
1947 | 1947 | | |
1948 | 1948 | | |
1949 | | - | |
1950 | | - | |
| 1949 | + | |
| 1950 | + | |
1951 | 1951 | | |
1952 | 1952 | | |
1953 | | - | |
1954 | 1953 | | |
1955 | 1954 | | |
1956 | | - | |
1957 | | - | |
1958 | | - | |
1959 | | - | |
1960 | 1955 | | |
1961 | 1956 | | |
1962 | 1957 | | |
| |||
0 commit comments