[tests] BuildLibraryWhichUsesResources should be NonParallelizable (#4979)

jonathanpeppers · web-flow · commit cde97d6e477e · 2020-08-05T11:02:16.000-05:00
Context: https://build.azdo.io/3947655 Since 396aca1 switched the `Xamarin.Android.Build.Tests.BuildTest.BuildLibraryWhichUsesResources` test to use AndroidX, it has been randomly failing with: (Restore target) -> /Library/Frameworks/Mono.framework/Versions/6.12.0/lib/mono/msbuild/Current/bin/NuGet.targets(124,5): error : Could not find file '/Users/runner/work/1/s/packages/xamarin.androidx.migration/1.0.0.1/c0hredtr.mkk'. I think this is happening because the test is parameterized and AndroidX has a large dependency tree. `[NonParallelizable]` should solve the issue.
diff --git a/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest.cs b/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest.cs
@@ -1905,6 +1905,7 @@ public void CheckLintConfigMerging ()
 		}
 
 		[Test]
+		[NonParallelizable] // fails on NuGet restore
 		[Category ("dotnet")]
 		/// <summary>
 		/// Reference https://bugzilla.xamarin.com/show_bug.cgi?id=29568

Original file line number	Diff line number	Diff line change
`@@ -1905,6 +1905,7 @@ public void CheckLintConfigMerging ()`
`1905`	`1905`	`}`
`1906`	`1906`
`1907`	`1907`	`[Test]`
	`1908`	`+ [NonParallelizable] // fails on NuGet restore`
`1908`	`1909`	`[Category ("dotnet")]`
`1909`	`1910`	`/// <summary>`
`1910`	`1911`	`/// Reference https://bugzilla.xamarin.com/show_bug.cgi?id=29568`