Commit eb6ea0b
authored
[Microsoft.Android.Sdk] fix %(AndroidSkip*) item metadata (#4959)
The `CheckMetadataSkipItemsAreProcessedCorrectly` test was failing
under a `dotnet` context due to item metadata missing, such as:
<AndroidSkipAddToPackage>True</AndroidSkipAddToPackage>
<AndroidSkipJavaStubGeneration>True</AndroidSkipJavaStubGeneration>
<AndroidSkipResourceExtraction>True</AndroidSkipResourceExtraction>
These metadata support AndroidX.Migration, and they are completely
missing from the item groups generated in
`Microsoft.Android.Sdk.AssemblyResolution.targets`.
After the `<ProcessAssemblies/>` MSBuild task is called, we should
call `<AppendCustomMetadataToItemGroup/>` to populate the missing
metadata.
The `CheckMetadataSkipItemsAreProcessedCorrectly` test now passes.1 parent 16478b7 commit eb6ea0b
File tree
2 files changed
+13
-2
lines changed- src/Xamarin.Android.Build.Tasks
- Microsoft.Android.Sdk/targets
- Tests/Xamarin.Android.Build.Tests
2 files changed
+13
-2
lines changedLines changed: 12 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
| 63 | + | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
66 | 66 | | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
67 | 77 | | |
68 | 78 | | |
69 | 79 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
| 215 | + | |
215 | 216 | | |
216 | 217 | | |
217 | 218 | | |
| |||
0 commit comments