Skip to content

Commit f1691f2

Browse files
committed
ff
1 parent 42ca9fc commit f1691f2

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

src/Xamarin.Android.Build.Tasks/Tasks/ResolveAssemblies.cs

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ bool Execute (DirectoryAssemblyResolver resolver)
102102
}
103103
}
104104
topAssemblyReferences.Add (assemblyDef);
105-
Log.LogDebugMessage ($"Attempting to Add {Path.GetFullPath (assemblyDef.MainModule.FullyQualifiedName)}");
106105
assemblies.Add (Path.GetFullPath (assemblyDef.MainModule.FullyQualifiedName));
107106
}
108107
} catch (Exception ex) {
@@ -146,36 +145,31 @@ JToken GetTargetFrameworkMonikerForNuget (JToken targets)
146145
{
147146
foreach (var targetMoniker in TargetMonikers) {
148147
var targetMonikerWithoutRuntimeIdentifier = targetMoniker.ItemSpec;
149-
if (targets[targetMonikerWithoutRuntimeIdentifier] != null)
150-
return targets[targetMonikerWithoutRuntimeIdentifier];
148+
if (targets [targetMonikerWithoutRuntimeIdentifier] != null)
149+
return targets [targetMonikerWithoutRuntimeIdentifier];
151150
}
152-
var enumerableTargets = targets.Cast<KeyValuePair<string, JToken>>();
153-
return enumerableTargets.FirstOrDefault().Value ?? null;
151+
var enumerableTargets = targets.Cast<KeyValuePair<string, JToken>> ();
152+
return enumerableTargets.FirstOrDefault ().Value ?? null;
154153
}
155154

156155
AssemblyDefinition ResolveRuntimeAssemblyForReferenceAssembly (JToken targets, DirectoryAssemblyResolver resolver, AssemblyNameDefinition assemblyNameDefinition)
157156
{
158157
var targetFramework = GetTargetFrameworkMonikerForNuget (targets);
159158
if (targetFramework == null)
160159
return null;
161-
Log.LogDebugMessage ($"Got targetFramework");
162160
var packageRoot = targetFramework.Cast<JProperty>().FirstOrDefault (x => x.Name.StartsWith (assemblyNameDefinition.Name));
163161
if (packageRoot == null)
164162
return null;
165163
var packageName = packageRoot.Name;
166-
Log.LogDebugMessage ($"Got packageRoot {packageName}");
167-
var package = packageRoot.FirstOrDefault();
164+
var package = packageRoot.FirstOrDefault ();
168165
if (package == null)
169166
return null;
170-
Log.LogDebugMessage ($"Got package");
171-
var runtime = package["runtime"];
167+
var runtime = package ["runtime"];
172168
if (runtime == null)
173169
return null;
174-
Log.LogDebugMessage ($"Got runtime");
175170
var property = runtime.FirstOrDefault () as JProperty;
176171
if (property == null)
177172
return null;
178-
Log.LogDebugMessage ($"Got property");
179173
var path = Path.Combine (NuGetPackageRoot, packageName, property.Name);
180174
Log.LogDebugMessage ($"Attempting to load {path}");
181175
return resolver.Load (path, forceLoad: true);

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/PackagingTest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -346,6 +346,7 @@ protected override void OnResume()
346346
"System.dll",
347347
"System.Runtime.Serialization.dll",
348348
"System.IO.Packaging.dll",
349+
"System.IO.Compression.dll",
349350
"Mono.Android.Export.dll",
350351
"App1.dll",
351352
"FormsViewGroup.dll",

0 commit comments

Comments
 (0)