Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit EnableNETAnalyzers usage and fix CA1305 instances in Xamarin.Android.Build.Tasks #8109

Open
pjcollins opened this issue Jun 5, 2023 · 0 comments
Open

Audit EnableNETAnalyzers usage and fix CA1305 instances in Xamarin.Android.Build.Tasks #8109

pjcollins opened this issue Jun 5, 2023 · 0 comments
Assignees
@dellis1972 @jonathanpeppers @pjcollins
Labels
Area: xamarin-android Build Issues building the xamarin-android repo *itself*.
Milestone
Under Consideration

Comments

@pjcollins
Copy link
Member

pjcollins commented Jun 5, 2023 •
edited
Loading

Context: #7993
Context: #8110

We should audit/fix instances of CA1305 in the following projects:

  • src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj
  • src/Xamarin.Android.Tools.Aidl/Xamarin.Android.Tools.Aidl.csproj
  • src/Xamarin.Android.Tools.JavadocImporter/Xamarin.Android.Tools.JavadocImporter.csproj

We should also revisit CA1309 and CA1310 (as set in Configuration.props to see if we can enable these errors more widely as well.
@pjcollins pjcollins added the Area: xamarin-android Build Issues building the xamarin-android repo *itself*. label Jun 5, 2023
@pjcollins pjcollins added this to the Under Consideration milestone Jun 5, 2023
@ghost ghost added the needs-triage Issues that need to be assigned. label Jun 5, 2023
@pjcollins pjcollins removed the needs-triage Issues that need to be assigned. label Jun 5, 2023
@pjcollins pjcollins mentioned this issue Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dellis1972 dellis1972

@jonathanpeppers jonathanpeppers

@pjcollins pjcollins

Labels
Area: xamarin-android Build Issues building the xamarin-android repo *itself*.
Projects
None yet
Milestone
Under Consideration
Development

No branches or pull requests
3 participants
@dellis1972 @jonathanpeppers @pjcollins