Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I extend retention period of existing symbol indices (without symbol packages)? #2466

Closed
Tracked by #2447
dagood opened this issue Apr 3, 2019 · 18 comments
Closed
Tracked by #2447

Comments

@dagood
Copy link
Member

dagood commented Apr 3, 2019

At release time, expiration date needs to be extended from 180 days to 10950 days (30 years). In earlier infra, this was done by publishing the same symbol packages again with the longer expiration date.

How is this done when some bits aren't in the symbol packages?

I imagine you could by downloading all the bits and pushing them back up, but how is that done in a release context? Is there tooling?

@jcagme
Copy link
Contributor

jcagme commented Apr 3, 2019

FYI @JohnTortugo

@tmat
Copy link
Member

tmat commented Apr 3, 2019

I believe we should set the expiration data to the required value right away for all builds, so that we do not need to ever extend it.

@markwilkie
Copy link
Member

Moving to P7

@JohnTortugo
Copy link
Contributor

Anyone see an issue with just extending the expiration data from the start? Who can confirm that the expiration period should be?

@dagood
Copy link
Member Author

dagood commented Apr 17, 2019

Anyone see an issue with just extending the expiration data from the start?

@mikem8361 might have thoughts here. I don't know who would specifically care about overusing symbol indexing/storage space. Maybe until we get a bill, nobody cares. 😄

@mikem8361
Copy link
Member

If we are talking about extending the expiration date to 30 years for every daily build that might add up and actually cost some storage space. I'm not basing that on any data I have, just a feeling :).

If we can extend only for the potential release builds, then that shouldn't be a problem at all. The old prodcon final publish job had a build variable that could be set to 10950 days. Not sure how things work for releases anymore.

We only have republishing as far as tooling to extend the expiration date.

@jcagme
Copy link
Contributor

jcagme commented Jun 3, 2019

@JohnTortugo is this done? If not should this be done be P7?

@JohnTortugo
Copy link
Contributor

It's not done. Currently the expiration date is 10 years. Not a blocker for P6 and IMO not a blocker for P7 as well.

I think now that we are going to have a set or rings where we promote builds through, we might solve this problem by increment the expiration date once the build reach a certain ring. That way we wouldn't increment the expiration date for every build.

@riarenas
Copy link
Member

@JohnTortugo should we move this to the Ringed releases epic? dotnet/arcade#2891

@JohnTortugo
Copy link
Contributor

Yeah, I think this should be part of the Ringed release epic. Can you please move it? I don't know why but the 'Epic dropdown' isn't showing up for me.

@riarenas
Copy link
Member

Yep I think it's broken right now 😢

@dagood
Copy link
Member Author

dagood commented Sep 26, 2019

Works in ZenHub app.

@riarenas
Copy link
Member

Works in ZenHub app.

Didn't even know that was a thing. Thanks Davis

@dagood
Copy link
Member Author

dagood commented Sep 26, 2019

I ended up there accidentally at some point. Funny that it's ended up useful. 😄

@jcagme jcagme changed the title How do I extend retention period of existing symbol indices (without symbol packages)? [QCR][Validation ring] How do I extend retention period of existing symbol indices (without symbol packages)? Mar 13, 2020
@michellemcdaniel
Copy link
Contributor

@riarenas says that build's symbol retention is now 10 years. Is that long enough? Ricardo, please let me know if that's incorrect

@dagood
Copy link
Member Author

dagood commented Mar 19, 2021

I haven't heard anything about the requirement dropping from 30 years to 10 years. Some teams have been ok with 10, but AFAIK the runtime was always 30 years.

@michellemcdaniel
Copy link
Contributor

Out of scope for dotnet/arcade#6418.

@michellemcdaniel michellemcdaniel changed the title [QCR][Validation ring] How do I extend retention period of existing symbol indices (without symbol packages)? How do I extend retention period of existing symbol indices (without symbol packages)? Apr 22, 2021
@dkurepa dkurepa transferred this issue from dotnet/arcade Jun 2, 2023
@dkurepa dkurepa added this to the Improve Release Process milestone Jun 2, 2023
@andriipatsula
Copy link
Member

Closing this as the issue is almost 4 years old and we don’t have plans to work on this in the near future. In case you believe the issue needs resolution - please reopen it and provide a reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants