Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest requests package breaks helix installer #12332

Closed
MattGal opened this issue Jan 26, 2023 · 2 comments
Closed

Latest requests package breaks helix installer #12332

MattGal opened this issue Jan 26, 2023 · 2 comments
Assignees
Labels
Critical Ops - Compliance First-responder-style issues handled by the Operations V-Team due to prioritization or urgency level

Comments

@MattGal
Copy link
Member

MattGal commented Jan 26, 2023

Traceback (most recent call last):
  File "installer.py", line 5, in <module>
    import requests
  File "C:\h\scripts\helix-scripts\requests\__init__.py", line 105, in <module>
    check_compatibility(
  File "C:\h\scripts\helix-scripts\requests\__init__.py", line 86, in check_compatibility
    raise Exception("You need either charset_normalizer or chardet installed")

First seen on on-prem machines, this seems to have started on 1/12/2023 when the requests library got updated. I am prepping a PR to staging to hopefully address this; we can discuss hotfixing later today once this looks good.

Release Note Description

Downgraded Helix client requests package to address issues seen with 1/12 release

@MattGal MattGal added the Ops - Compliance First-responder-style issues handled by the Operations V-Team due to prioritization or urgency level label Jan 26, 2023
@MattGal MattGal self-assigned this Jan 26, 2023
@MattGal
Copy link
Member Author

MattGal commented Jan 26, 2023

Merged bypassing policy (it's just changing the package lists) and am watching the latest main run

@MattGal
Copy link
Member Author

MattGal commented Jan 31, 2023

Rolled out last week and is holding. #12335 tracks trying other approaches; closing.

@MattGal MattGal closed this as completed Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical Ops - Compliance First-responder-style issues handled by the Operations V-Team due to prioritization or urgency level
Projects
None yet
Development

No branches or pull requests

1 participant