-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add msquic to Centos 7 Helix queue #12540
Comments
@wfurt given you have the linked PR open, is this a request to add it to our non-docker images, or just a tracking issue about doing the work to support it in docker? |
We also have test runs in full Helix queue and it is part of the hunt for complete coverage. |
OK, tossing on FROps backlog. |
With microsoft/msquic#3422 still open and the suggested fix not merged, I am checking with @wfurt about this this morning. |
Chatted with @wfurt today. The work in the helix machines repo is already done. That is, we already install libmsquic from the Microsoft package source on all Centos 7 images, and routinely update the base images from Azure. Every time this base image update happens, whatever is on the Microsoft package feed source is fetched and installed, so whenever this is updated our existing processes will address the issue. As we don't want to introduce building from source into the plain helix images, there is no work for DncEng to do here, so I am closing the issue. |
I check the Helix repro machine and looks good.
so it is on auto-update and it will pick up fixes when ready. It was not clear to me from the original description. |
We generally need to do
|
Cheap to add, reopening and I'll add that. |
Thanks @MattGal. We will also need fix from MsQuic but since the Queue is on regular updates we will just need to wait. |
should be handled by https://dev.azure.com/dnceng/internal/_git/dotnet-helix-machines/pullrequest/29760, rolling out this week |
This rolled out today. If you continue to have issues with Centos.7 images please ping dnceng. |
thanks @MattGal for quick fix |
This is follow-up on #10253 (comment)
I don't know if it is just time lapse, but it should be possible now. see dotnet/dotnet-buildtools-prereqs-docker#800 for detail.
openssl11 needed my msquic comes from EPEL repo. So it needs to be added if it is not already there.
cc: @ManickaP @CarnaViire @MattGal
The text was updated successfully, but these errors were encountered: