Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darc] Darc should be able to update Arcade's src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/Versions.props #1956

Closed
jcagme opened this issue Feb 1, 2019 · 2 comments
Closed

[Darc] Darc should be able to update Arcade's src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/Versions.props #1956

jcagme opened this issue Feb 1, 2019 · 2 comments

Comments

@jcagme
Copy link
Contributor

jcagme commented Feb 1, 2019

For now we'd need to keep versions defined in src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/Versions.props hard coded since Darc does not know how to deal with this file.
@jcagme jcagme mentioned this issue Feb 1, 2019
Merged
@tmat
Copy link
Member

tmat commented Feb 4, 2019

I don't think Darc should be updating this file. Darc should only be updating global.json in repo root or eng\common.

This is more or less duplicate of #1599.

@jcagme
Copy link
Contributor Author

jcagme commented Feb 25, 2019

This was fixed by #1990

@jcagme jcagme closed this as completed Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmat @jcagme