Need API to read SourceLink information from Windows PDBs

[JohnTortugo]

Issue originated after discussion on this other issue: dotnet/arcade-services#2467

It's what the title say. We need a tool that can read SourceLink information from Windows PDBs. See messages from @tmat below for better context.

From @JohnTortugo here:

AFAIU right now sourcelink cli tool can only handle Portable PDBs and the PDBs that we have during publish/release are Windows PDBs. I'm still investigating.

From @tmat here:

I don't think we have the necessary APIs in Microsoft.DiaSymReader/Native to read native source link data (they are stored in a different stream within the PDB than managed ones). No problem adding those APIs it's just work.

So I suggest we separate validation of Source Link Portable PDBs and native (C++ generated) PDBs. Let's make sure our Portable PDBs are good first and later on we can add validation of native PDBs.

[jcagme]

Hey @JohnTortugo what's the latest here? Is this required for your work to be completed by end of June?

[JohnTortugo]

This is not a blocker for publishing itself. It's a blocker for how complete our validation process is: currently our source link validation is only performed in Portable PDBs.

I don't think this is a blocker for P6/P7 . @mmitche , @markwilkie for awareness

[jcagme]

Given that works only on portable PDBs could we safely say that things were validated? What's the risk of not validating Windows only PDBs?

[JohnTortugo]

I think the Windows PDB's are mostly from building C++ sources. @tmat can answer that question better.

[tmat]

The only concern imo is PDBs built by C++.

[riarenas]

Moving to the ringed releases epic.

[michellemcdaniel]

Out of scope for #6418.

[jakubstilec]

[Async Triage]: @adiaaida where this should go when it was removed from #6418? When it hasn't been done for 2 years maybe we can close it?

[markwilkie]

@mmitche - wondering if we should/could close this one too....

[MattGal]

[Async Triage]: I favor closing the issue; if someone cares the issue would need to be in https://github.com/dotnet/sourcelink anyways.

[jakubstilec]

[Async Triage]: no objection to close it