Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Darc] Use Directory.Build.props for Arcade SDK versions #322

Closed
jcagme opened this issue Jul 12, 2018 · 3 comments
Closed

[Darc] Use Directory.Build.props for Arcade SDK versions #322

jcagme opened this issue Jul 12, 2018 · 3 comments

Comments

@jcagme
Copy link
Contributor

jcagme commented Jul 12, 2018

Originally, the Arcade SDK version was planned to be maintained in global.json. In #320 a change to this was discussed and now it was agreed that the version is going to be stored in Directory.Build.props.

Currently Darc will try to update, if needed, the version in global.json so we need to make the change to track Arcade SDK's version in Directory.Build.props instead.

@jcagme jcagme changed the title Use Directory.Build.props for Arcade SDK versions [Darc] Use Directory.Build.props for Arcade SDK versions Jul 12, 2018
@tmat
Copy link
Member

tmat commented Jul 13, 2018

I don't think there has been any conclusion yet. I specifically dislike adding the version to Directory.Build.props.

@jcagme
Copy link
Contributor Author

jcagme commented Jul 13, 2018

Got it, will keep an eye the original issue to make sure we react as needed

@jcagme
Copy link
Contributor Author

jcagme commented Sep 14, 2018

We've decided to keep the version in global.json and this is what Darc updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants