-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Where to set build architecture in Arcade? #4209
Comments
Is this helpful by any chance? https://github.com/dotnet/arcade/blob/master/Documentation/ArcadeSdk.md If not, what are you trying to do specifically and we can certainly help. |
I believe it isn't correct that Arcade handles build and target arch. This was a challenge in the Arcade onboarding process for core*, and we decided not to try to standardize it (and I believe this means Arcade has continued not to have a default implementation). This is one of the road bumps that's come up in core* repo consolidation, that everyone has handled it differently. Another way to look at this is how Core-SDK targets e.g. win-x86. In CI, x86 shows up here in the build matrix: which is passed to build.cmd as which is directed to which is used by the build infra (a line your PR touches!): Arcade isn't involved at any point if I followed it right. |
That makes sense to me. Should I close this issue and continue my efforts to update |
In my opinion, yep. @johnbeisner, do you have any feedback on this issue? |
All my concerns have been resolved, so I am going to close this issue now. Please feel free to re-open if anyone has any outstanding questions. |
Over at another issues (dotnet/installer#4102 (comment)) I was told that arcade handles all the build architecture stuff for .NET Core projects:
I tried looking for this code in arcade it, but couldn't find any obvious answer. Anyone know how I can find this code that sets up architecture related stuff for consuming projects in arcade?
Additionally, does that mean projects where they are setting up architecture need fixing? I am looking at code like:
https://github.com/dotnet/corefx/blob/cf28b7896a762f71c990a5896a160a4138d833c9/Directory.Build.props#L59-L62
The text was updated successfully, but these errors were encountered: