Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow VerifyClosure target to run independently from other validations #6098

Closed
NikolaMilosavljevic opened this issue Sep 2, 2020 · 0 comments · Fixed by #6101
Closed

Allow VerifyClosure target to run independently from other validations #6098

NikolaMilosavljevic opened this issue Sep 2, 2020 · 0 comments · Fixed by #6101
Assignees
@NikolaMilosavljevic

Comments

@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented Sep 2, 2020 •
edited
Loading

We need enable running VerifyClosure target independently from other validations. The change would be to update existing target condition to also evaluates to true if ShouldVerifyClosure property is set to true. Currently VerifyClosure only runs if SkipValidatePackage is false:

arcade/src/Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk/targets/framework.packaging.targets

Line 170 in e11b848

Condition="'$(SkipValidatePackage)' != 'true'"

This is needed for fixing this runtime issue: dotnet/runtime#31805

PR for that issue: dotnet/runtime#41698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolaMilosavljevic NikolaMilosavljevic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable VerifyClosure target to run independently of other validations NikolaMilosavljevic/arcade
1 participant
@NikolaMilosavljevic