Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk.txt encoding issues #6960

Closed
2 tasks
Tracked by #6560
lukas-lansky opened this issue Feb 16, 2021 · 2 comments
Closed
2 tasks
Tracked by #6560

sdk.txt encoding issues #6960

lukas-lansky opened this issue Feb 16, 2021 · 2 comments

Comments

@lukas-lansky
Copy link
Contributor

  • This issue is blocking
  • This issue is causing unreasonable pain

A part of the runtime issues discussed at length at dotnet/runtime#42397 is the fact that the sdk.txt mechanism doesn't play well with non-ASCII characters. We should specify encoding and make sure the .dotnet path gets through in cases like this:

> mv runtime runťime
> cd runťime
> ./dotnet.cmd
C:\Source\runťime\.dotnet
The system cannot find the path specified.
@ilyas1974
Copy link
Contributor

@tkapin is this something you can help get sorted? Should this go to the backlog or is there something that we can push forward and complete?

@tkapin
Copy link
Member

tkapin commented Mar 17, 2022

The scripts should be certainly respecting the filesystem capabilities (spaces, non-ASCII characters, etc. in paths), but this is a year old issue and it seems this doesn't cause any problems, which indicates the ROI isn't met. Closing as won't do, feel free to reopen if you thing we should invest into this.

@tkapin tkapin closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants