Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock runtime publishing #6988

Closed
1 of 2 tasks
epananth opened this issue Feb 19, 2021 · 10 comments
Closed
1 of 2 tasks

Unblock runtime publishing #6988

epananth opened this issue Feb 19, 2021 · 10 comments
Assignees

Comments

@epananth
Copy link
Member

epananth commented Feb 19, 2021

  • This issue is blocking
  • This issue is causing unreasonable pain

Issue -> #6987

To temporarily unblock runtime publishing we are going to use a different build pool for publishing.

@MattGal
Copy link
Member

MattGal commented Feb 19, 2021

@epananth and i chatted just now, we're going to synch with @riarenas . The thing about V3 publishing is that its choice of build pool is stuck in arcade's master branch, meaning we can't change this just for runtime ( I was thinking v2-style when I suggested it).

I think the risk is low (just changing the build pool) but there's a chance for delayed publishing for everyone while waiting for machines to spin up, and the things that wait on this might time out. As such, I'd like to get confirmation both from @epananth and @riarenas that we want to do this before proceeding.

@MattGal
Copy link
Member

MattGal commented Feb 19, 2021

Created the test branch Ricardo suggested to limit this to just runtime, and this PR: dotnet/runtime#48521 to use it.

@MattGal
Copy link
Member

MattGal commented Feb 19, 2021

Monitoring https://dnceng.visualstudio.com/internal/_build/results?buildId=1003468&view=results . Will put this into tracking if/when it succeeds.

@MattGal
Copy link
Member

MattGal commented Feb 23, 2021

Moving to tracking.

@MattGal
Copy link
Member

MattGal commented Feb 26, 2021

Just did this again: dotnet/runtime#48855

per @epananth it's looking like next week for a change that fixes this problem.

@MattGal
Copy link
Member

MattGal commented Mar 9, 2021

@epananth can I assign this to you since you're doing the unblocking?

@epananth epananth assigned epananth and unassigned MattGal Mar 9, 2021
@ilyas1974
Copy link
Contributor

@epananth, wanted to check in with you on this issue. Have we been able to roll out the fix for this?

@epananth
Copy link
Member Author

epananth commented Apr 6, 2021

I got my pr approved => #7086, will merge today...

@MattGal
Copy link
Member

MattGal commented Apr 19, 2021

@epananth can I get a status update here?

@epananth
Copy link
Member Author

epananth commented Apr 19, 2021

I merged this PR. So far did not see any issues with the runtime publishing. I believe we are using the main branch to publish for runtime. We can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants