Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA aka.ms links should point to blob storage #7253

Closed
michellemcdaniel opened this issue Apr 15, 2021 · 5 comments
Closed

GA aka.ms links should point to blob storage #7253

michellemcdaniel opened this issue Apr 15, 2021 · 5 comments
Assignees

Comments

@michellemcdaniel
Copy link
Contributor

After we publish to the stable blob storage locations, we should take that information, and point the GA aka.ms links at those blob storage locations. This would allow us to fix #7240 and #7239 without affecting the release.json file, and wouldn't require us to publish anything we don't want to

@michellemcdaniel michellemcdaniel self-assigned this Apr 15, 2021
@michellemcdaniel
Copy link
Contributor Author

/cc: @bozturkMSFT @leecow

@michellemcdaniel
Copy link
Contributor Author

michellemcdaniel commented Apr 15, 2021

I've written up some code that will create the mapping from the new dotnetcli location (ie, where repo propagation will move them to) and the aka.ms links those changes will correspond to. It spits out a json file that UpdateAkaMsLinks can read. I update UpdateAkaMsLinks to allow the specifying of a file that doesn't require any changes to it (right now, various bits are prepended to the file name to get the "final" version).

What's left to do:

  • Remove the original support that I added for GA. We don't want the links pointing to the visualstudio location at all.
  • Add tests for the changes in ReleaseCli
  • Add running of the tool to the staging pipeline, and have it dump the file on vsufile.
  • Add an additional running of UpdateAkaMsLinks to the release/RM pipeline for 5.0+.

@michellemcdaniel
Copy link
Contributor Author

@michellemcdaniel
Copy link
Contributor Author

The main part of this has been checked in and needs to be rolled out.

The part to turn on the actual creation of the links will need to be added to the RM/release pipelines

@michellemcdaniel
Copy link
Contributor Author

Opened a new issue for the final piece: #7318. Closing this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant