[release/9.5] Display help text for GenAI sensitive data when no messages (#11668)

* Display help text for enabling GenAI sensitive data when there are no messages

* Update

* Handle error spans

---------

Co-authored-by: James Newton-King <james@newtonking.com>

Author: github-actions[bot]

src/Aspire.Dashboard/Model/GenAI/GenAIVisualizerDialogViewModel.cs

@@ -91,7 +91,7 @@ public static GenAIVisualizerDialogViewModel Create(
         viewModel.InputMessages = viewModel.Items.Where(e => e.Type is GenAIItemType.SystemMessage or GenAIItemType.UserMessage or GenAIItemType.AssistantMessage or GenAIItemType.ToolMessage).ToList();
         viewModel.OutputMessages = viewModel.Items.Where(e => e.Type == GenAIItemType.OutputMessage).ToList();
 
-        viewModel.NoMessageContent = AllMessagesHaveNoContent(viewModel.InputMessages) && AllMessagesHaveNoContent(viewModel.OutputMessages);
+        viewModel.NoMessageContent = AllMessagesHaveNoContent(viewModel.InputMessages) && AllMessagesHaveNoContent(viewModel.OutputMessages) && viewModel.ErrorItem == null;
 
         return viewModel;
     }
@@ -100,7 +100,8 @@ private static bool AllMessagesHaveNoContent(List<GenAIItemViewModel> messageVie
     {
         if (messageViewModels.Count == 0)
         {
-            return false;
+            // Microsoft.Extensions.AI doesn't output any message telemetry when sensitive data isn't enabled.
+            return true;
         }
 
         foreach (var messageViewModel in messageViewModels)

tests/Aspire.Dashboard.Tests/Model/GenAIVisualizerDialogViewModelTests.cs

@@ -542,6 +542,50 @@ public void Create_GenAISpanAttributesWithoutContent_HasNoMessageContent()
         Assert.True(vm.NoMessageContent);
     }
 
+    [Fact]
+    public void Create_NoMessages_HasNoMessageContent()
+    {
+        // Arrange
+        var repository = CreateRepository();
+
+        var attributes = new KeyValuePair<string, string>[]
+        {
+            KeyValuePair.Create(GenAIHelpers.GenAISystem, "System!"),
+            KeyValuePair.Create("server.address", "ai-server.address"),
+        };
+
+        var addContext = new AddContext();
+        repository.AddTraces(addContext, new RepeatedField<ResourceSpans>()
+        {
+            new ResourceSpans
+            {
+                Resource = CreateResource(),
+                ScopeSpans =
+                {
+                    new ScopeSpans
+                    {
+                        Scope = CreateScope(),
+                        Spans =
+                        {
+                            CreateSpan(traceId: "1", spanId: "1-1", startTime: s_testTime.AddMinutes(1), endTime: s_testTime.AddMinutes(10), attributes: attributes)
+                        }
+                    }
+                }
+            }
+        });
+        Assert.Equal(0, addContext.FailureCount);
+
+        var span = repository.GetSpan(GetHexId("1"), GetHexId("1-1"))!;
+        var spanDetailsViewModel = SpanDetailsViewModel.Create(span, repository, repository.GetResources());
+
+        // Act
+        var vm = Create(repository, spanDetailsViewModel);
+
+        // Assert
+        Assert.Empty(vm.Items);
+        Assert.True(vm.NoMessageContent);
+    }
+
     private static GenAIVisualizerDialogViewModel Create(
         TelemetryRepository repository,
         SpanDetailsViewModel spanDetailsViewModel)