Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Idea: Connecting Metrics to Traces #336

Closed
eerhardt opened this issue Oct 17, 2023 · 6 comments · Fixed by #4629
Closed

Feature Idea: Connecting Metrics to Traces #336

eerhardt opened this issue Oct 17, 2023 · 6 comments · Fixed by #4629

Comments

@eerhardt
Copy link
Member

Now that we have both Metrics and Traces in the dashboard, we should consider connecting the two, so I can drill in to data I see in my Metrics graphs, and figure out why something is taking so long.

For example, in the sample app, the first time I click the cart button on the top right, it causes a spike in duration of HTTP requests.

image

It would be great if I could drill in to that request to see what took so long.

One idea is to use exemplars, which is a feature in OpenTelemetry that allows getting a value in a histogram bucket and being able to see the trace ID for that value, so you can jump to a trace.

cc @davidfowl @JamesNK @samsp-msft

@samsp-msft
Copy link
Member

This is exactly what examplars are for. They are still pretty rough at this stage, and you don't get to control which activities are tracked by the exemplar. I would suggest this is a .NET 9 feature.

@cijothomas, @CodeBlanch

@dbreshears dbreshears added this to the some time after preview milestone Oct 18, 2023
@danmoseley danmoseley removed this from the needs milestone (for GA) milestone Nov 13, 2023
@davidfowl davidfowl added this to the Backlog milestone Jan 27, 2024
@samsp-msft
Copy link
Member

The exemplar support is going to be shipped with the OpenTelemetry.NET 1.9 release next week.

@JamesNK

@samsp-msft
Copy link
Member

I would suggest something like:
image
Where the exemplars are shown as points on the graph. Hovering over the point will show the value and time.

Clicking a point will bring up a popup panel showing the details of the point, and the ability to link off to the traces page or logs for the SpanId associated with the exemplar.
image

@samsp-msft samsp-msft removed this from the Backlog milestone Jun 17, 2024
@samsp-msft
Copy link
Member

Clearing milestone so we can re-triage

@mitchdenny
Copy link
Member

@samsp-msft I'm assuming this is something we will do eventually right? So can go back on Backlog (its not something we would not do ... its just about resources & priorities).

@samsp-msft
Copy link
Member

@mitchdenny Exemplars is the cool new feature for OTel and something we will be making noise about. I want people to be able to use/view them for Aspire from the dashboard.
The OTel library support has shipped, what's missing at this point is support in the dashboard.

@davidfowl davidfowl added this to the 8.1 milestone Jun 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants