Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebToolsE2E][Aspire] For an Azure Function app under Aspire orchestration, we don't show any metrics info even if select function resource #6482

Closed
v-bennettyue opened this issue Oct 24, 2024 · 10 comments
Assignees
Labels
area-integrations Issues pertaining to Aspire Integrations packages azure Issues associated specifically with scenarios tied to using Azure azure-functions Issues related to the Azure Functions integration 💥 blocking-release 💥 Issues that would block us from shipping/releasing
Milestone

Comments

@v-bennettyue
Copy link

INSTALL STEPS

  1. Clean machine: Win11 x64 23h2 ENU
  2. Install Dev17.12 GA
  3. Install Aspire 9.0 GA
  4. Apply feed

REPRO STEPS

  1. New > Azure Function > .NET 8.0 Isolated (Long Term Support) > Select "Http trigger" as Function, click "Enlist in Aspire orchestration" > Create
  2. Build and run
  3. Navigate to Metrics of the dashboard

Note: For .net 9.0 azure function, it will encounter bug #6452

ACTUAL
There is Function resource available, but there is no information on the page
Image

EXPECTED
There is complete function information on Metrics page

@captainsafia
Copy link
Member

@v-bennettyue Can you confirm what version of the Aspire.Hosting.Azure.Functions package is being referenced in your project file? I think that you might be on an older version which is what is causing this issue.

@captainsafia captainsafia added area-integrations Issues pertaining to Aspire Integrations packages azure Issues associated specifically with scenarios tied to using Azure labels Oct 24, 2024
@balachir
Copy link

@captainsafia I'm able to reproduce this too. The version I see in the csproj is 9.0.0-rtm.24523.16.

@captainsafia
Copy link
Member

@balachir Hmmm....something might have gone wrong with the scaffolding then. We don't ship a 9.0.0-rtm.24523.16 version of the Aspire.Hosting.Azure.Functions package. Perhaps that's the version you're seeing of the Aspire.Hosting package?

@balachir
Copy link

@captainsafia I tried this again using the latest version of Functions templates (version 4.100.0). I can still reproduce this issue that's described in the Repro Steps. It shows the Metrics tab, but when you select the function app, it says "No metrics for the selected resource".

Here's my AppHost project file - this matches the versions available from the latest 9.0 Aspire build.

Image

@joperezr
Copy link
Member

@captainsafia is investigating into this further. This may require changes on the aspire repo.

@balachir
Copy link

@v-bennettyue can you try the workaround that Safia mentioned in #6452 ? Does that solve this issue?

@v-bennettyue
Copy link
Author

@captainsafia @balachir This issue not repro on .net 9.0 Azure Functions + Aspire, but it still repro on .net 8.0 Azure Functions + Aspire, the latest version of the toolset is 4.101.0.

@captainsafia
Copy link
Member

@captainsafia @balachir This issue not repro on .net 9.0 Azure Functions + Aspire, but it still repro on .net 8.0 Azure Functions + Aspire, the latest version of the toolset is 4.101.0.

Yes, this is expected behavior for now. Only the 9.0 templates have been updated for Functions. Once we have confidence in the quality of those, we'll make the same updates to the 8.0 templates. We'll let you know when that happens.

@balachir
Copy link

balachir commented Nov 4, 2024

@captainsafia thanks, it's great that this works for 9.0 Functions template now. I believe we don't need to track this as a blocking issue for Aspire 9.0 GA release anymore. Shall we still keep this issue active to track the 8.0 Functions template case? If you agree, you can go and update the milestone and priority as appropriate. Thanks!

@captainsafia
Copy link
Member

@captainsafia Let's go ahead and close this out for now.

We're primarily targeting support for .NET 9 with the preview of this feature. As GA approaches, we'll do another round of testing for .NET 8.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages azure Issues associated specifically with scenarios tied to using Azure azure-functions Issues related to the Azure Functions integration 💥 blocking-release 💥 Issues that would block us from shipping/releasing
Projects
None yet
Development

No branches or pull requests

4 participants