Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebToolsE2E][Aspire] Some strings in Aspire 9.1 Dashboard are enclosed with a border. #7166

Closed
vmykagapuz opened this issue Jan 20, 2025 · 1 comment
Assignees
Milestone

Comments

@vmykagapuz
Copy link

vmykagapuz commented Jan 20, 2025

REGRESSION

  1. Worked in Aspire 9.0.0 and 9.0.1

INSTALL STEPS

  1. Clean machine: Win11 x64 23h2 ENU
  2. Install SDK 9.0.102
  3. Install latest Aspire 9.1.0-preview.1.25069.2

REPRO STEPS

  1. Create an Aspire Starter App using following commands:
dotnet new aspire-starter -o AspireStarterApp
cd AspireStarterApp/AspireStarterApp.AppHost
  1. Run the project in CMD, and open URL in the browser.
    dotnet run
  2. Navigate to Structured and Traces > type something in the filter search bar > Enter
  3. Click the No filters button and check the "Add filter" string
  4. Press Shift + ? to show dashboard shortcut and check the "Help" string
  5. Press Shift + s to go to Settings and check the "Settings" string

ACTUAL
The following strings are enclosed with a border:

Add filter
Image

Help
Image

Settings
Image

EXPECTED
The mentioned strings should not be enclosed with a border.

@joperezr joperezr added untriaged New issue has not been triaged area-dashboard labels Jan 21, 2025
@adamint adamint removed the untriaged New issue has not been triaged label Jan 21, 2025
@adamint adamint self-assigned this Jan 21, 2025
@adamint adamint added this to the 9.1 milestone Jan 21, 2025
@adamint
Copy link
Member

adamint commented Jan 23, 2025

I'm going to close this as expected behavior. Using the keyboard shortcut, we open a modal. fluentui-blazor auto-focuses the first element, which happens to be a header here. It's a nice indication of where keyboard focus is. This behavior does not happen when clicking the help (or settings) navbar items.

@adamint adamint closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants