Skip to content

Conversation

@afscrome
Copy link
Contributor

@afscrome afscrome commented Jul 1, 2025

Description

Follow up to #10097 - migrating event subscriptions in tests to use the new OnXYZ extension methods on the ResourceBuilder

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@afscrome afscrome requested a review from mitchdenny as a code owner July 1, 2025 19:50
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 1, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 1, 2025
afscrome added 2 commits July 1, 2025 21:08
Use the same Eventing object throughout, rather than two.
@afscrome afscrome force-pushed the use-resource-event-methods-in-tests branch from 1f26b90 to 8b8e5ec Compare July 1, 2025 20:30
@afscrome afscrome added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 1, 2025
@mitchdenny mitchdenny merged commit 83bc887 into dotnet:main Jul 2, 2025
496 of 498 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants