Skip to content

Commit 7d035f4

Browse files
authored
Revert "Add timeout back to hanging test (#1480)" (#1482)
This reverts commit 09adc4a.
1 parent 09adc4a commit 7d035f4

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

test/Microsoft.AspNetCore.SignalR.Tests.Utils/TaskExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ namespace System.Threading.Tasks
88
{
99
public static class TaskExtensions
1010
{
11-
private const int DefaultTimeout = 1000 * 60;
11+
private const int DefaultTimeout = 5000;
1212

1313
public static Task OrTimeout(this Task task, int milliseconds = DefaultTimeout, [CallerMemberName] string memberName = null, [CallerFilePath] string filePath = null, [CallerLineNumber] int? lineNumber = null)
1414
{

test/Microsoft.AspNetCore.SignalR.Tests/EndToEndTests.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,8 @@ public async Task ConnectionCanSendAndReceiveDifferentMessageSizesWebSocketsTran
290290
logger.LogInformation("Sent message", bytes.Length);
291291

292292
logger.LogInformation("Receiving message");
293-
var receivedData = await receiveTcs.Task.OrTimeout();
293+
// No timeout here because it can take a while to receive all the bytes
294+
var receivedData = await receiveTcs.Task;
294295
Assert.Equal(message, Encoding.UTF8.GetString(receivedData));
295296
logger.LogInformation("Completed receive");
296297
}

0 commit comments

Comments
 (0)