Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More InputComponents for common use cases #10529

Closed
sjohag opened this issue May 24, 2019 · 5 comments
Closed

More InputComponents for common use cases #10529

sjohag opened this issue May 24, 2019 · 5 comments
Labels
area-blazor Includes: Blazor, Razor Components enhancement This issue represents an ask for new feature or an enhancement to an existing one ✔️ Resolution: Duplicate Resolved as a duplicate of another issue Status: Resolved
Milestone

Comments

@sjohag
Copy link

sjohag commented May 24, 2019

Please add more components in InputComponents for Blazor, covering common tasks like file uploading and select-multiple (perhaps render something like bootstrap-select).
A simple grid and a modal wouldn't hurt either.
And keep up the good work, you are making amazing progress!

@Pilchie Pilchie added the area-blazor Includes: Blazor, Razor Components label May 24, 2019
@3x0dv5
Copy link

3x0dv5 commented May 25, 2019

I agree, although it is straightforward to add your own components.

  1. dotnet new razorcomponent -o CcInputPassword
    image

  2. I like to separate the razor syntax from the actual c# code, so create a cs file to keep the c#. Inherit your class from InputBase
    image

image

  1. Inherit from the "cs code" and implement the razor markup
    image

  2. ready to use on your form
    image

@sjohag
Copy link
Author

sjohag commented May 26, 2019

Some are straightforward, some are not.
I think that file uploading requires JS-interop, and select-multiple is not very useful with standard rendering in most browsers, slightly better on mobile phones thanks to the lack of keyboard (no ctrl-button).

Your implementation of InputPassword is simple and clean, but almost identical to the existing InputText. If the existing implementation had a "type"-parameter (enum), making your own wouldn’t be necessary. Same goes for InputDate, a "type"-parameter (datetime, datetime-local etc) would make it more useful.

It would be nice and more productive if the basic interaction elements were included.

@3x0dv5
Copy link

3x0dv5 commented May 26, 2019

Well yes and no. For the functionality I wanted to show you are right, a input type=password would be enough, but my password component has a bit more than just be a password field. I also noticed that I could inherited from InputText and not InputBase<>, but well it is a sample.

This is still work in progress and I believe that the guys will add a bit more love to this, meanwhile everyone is free to create their own open source razor component libs and nuget them ;) the purpose of a framework is to provide the foundations to build on top of it.

Personally I am loving it!

@mkArtakMSFT mkArtakMSFT added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Jun 7, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.1.0 milestone Jun 7, 2019
@mkArtakMSFT mkArtakMSFT modified the milestones: 3.1.0, 5.0.0 Aug 12, 2019
@mkArtakMSFT mkArtakMSFT modified the milestones: 5.0.0, 5.0.0-preview1 Aug 19, 2019
@mkArtakMSFT
Copy link
Member

Thanks for contacting us. This ask is already covered as part of multiple other issues. So closing this as we will be handling these instead.

@mkArtakMSFT mkArtakMSFT added the ✔️ Resolution: Duplicate Resolved as a duplicate of another issue label Jan 23, 2020
@ghost ghost added the Status: Resolved label Jan 23, 2020
@mkArtakMSFT
Copy link
Member

#12205, #15405, #5519

@ghost ghost locked as resolved and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components enhancement This issue represents an ask for new feature or an enhancement to an existing one ✔️ Resolution: Duplicate Resolved as a duplicate of another issue Status: Resolved
Projects
None yet
Development

No branches or pull requests

4 participants