Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement accept back pressure for libuv transport #10978

Closed
davidfowl opened this issue Jun 7, 2019 · 5 comments
Closed

Implement accept back pressure for libuv transport #10978

davidfowl opened this issue Jun 7, 2019 · 5 comments
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Milestone
Backlog

Comments

@davidfowl
Copy link
Member

Today the libuv transport accepts connections into a queue before the server calls accept. We should bound this queue and only accept a certain number of connections.

cc @halter73
@analogrelay
Copy link
Contributor

How would this affect a customer?

@analogrelay
Copy link
Contributor

Pretty unlikely to be done in 3.0 at this point... The default is sockets now, right?

@davidfowl
Copy link
Member Author

Yep, we can punt for 3.0

@analogrelay analogrelay added this to the Backlog milestone Jun 18, 2019
@davidfowl
Copy link
Member Author

Related to #13295

@davidfowl
Copy link
Member Author

Closing this, it's not important

@ghost ghost locked as resolved and limited conversation to collaborators May 16, 2020
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@analogrelay @davidfowl @amcasey