Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate IRequestBodyPipeFeature and IHttpRequestFeature.Body #12620

Open
Tratcher opened this issue Jul 26, 2019 · 2 comments
Open

Consolidate IRequestBodyPipeFeature and IHttpRequestFeature.Body #12620

Tratcher opened this issue Jul 26, 2019 · 2 comments
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions breaking-change This issue / pr will introduce a breaking change, when resolved / merged. enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-nice-to-have This label is used by an internal tool
Milestone

Comments

@Tratcher
Copy link
Member

For 3.0.0-preview8 we consolidated all of the response body APIs onto the new IHttpResponseBodyFeature. We should do something similar for request bodies to make them more reliable to shim.

New API:
IHttpRequestBodyFeature

  • Stream
  • PipeReader
  • DisableBuffering - Maybe we don't need to bring this one back. We obsoleted IHttpBufferingFeature and nobody was using DisableRequestBuffering. It's more common for people to want to enable buffering since we don't by default.

Obsolete:
IRequestBodyPipeFeature
IHttpRequestFeature.Body

https://github.com/aspnet/AspNetCore/blob/master/src/Http/Http.Features/src/IRequestBodyPipeFeature.cs
https://github.com/aspnet/AspNetCore/blob/master/src/Http/Http/src/Features/RequestBodyPipeFeature.cs

This isn't as high a priority as it was for response bodies because there are fewer APIs, the auto-adapters work better for the read scenario, and it's less common to shim the request body.

@Tratcher Tratcher added enhancement This issue represents an ask for new feature or an enhancement to an existing one breaking-change This issue / pr will introduce a breaking change, when resolved / merged. area-servers labels Jul 26, 2019
@Tratcher Tratcher changed the title Consolidate IRequestBodyPipeFeature and IHttpRequestFeature Consolidate IRequestBodyPipeFeature and IHttpRequestFeature.Body Jul 26, 2019
@analogrelay analogrelay added this to the Backlog milestone Jul 26, 2019
@davidfowl
Copy link
Member

@anurse I just realized we left the IRequestBodyPipeFeature which is super unfortunate. Is there any chance we can rectify this? It leaves us into a bit of limbo as that feature will likely be deprecated in a later release...

@ghost
Copy link

ghost commented Sep 29, 2022

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
@amcasey amcasey modified the milestones: .NET 8 Planning, Backlog Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions breaking-change This issue / pr will introduce a breaking change, when resolved / merged. enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-nice-to-have This label is used by an internal tool
Projects
None yet
Development

No branches or pull requests

5 participants